add support for borderTopLeftRadius and the three other one-corner-on… #1871
Conversation
…ly border radius props to ReactImageManager
| { | ||
| view.CornerRadius = new CornerRadius(radius); | ||
| var cornerRadius = view.CornerRadius; |
There was a problem hiding this comment.
view.CornerRadius [](start = 31, length = 17)
Can view.CornerRadius ever be null? You can see ReactViewManager uses this expression:
var cornerRadius = border.CornerRadius == null ? new CornerRadius() : border.CornerRadius;
``` #Closed
There was a problem hiding this comment.
Spoke with Yury. CornerRadius is a struct so it can't be null and a null check is not needed.
In reply to: 197945901 [](ancestors = 197945901)
rozele
changed the title
| /// <param name="radius">The border radius value.</param> | ||
| [ReactProp("borderRadius")] | ||
| public void SetBorderRadius(Border view, double radius) | ||
| [ReactPropGroup( |
There was a problem hiding this comment.
modify WPF implementation to match as well. test prop in Playground and provide code+screenshot for both UWP and WPF.
There was a problem hiding this comment.
@matthargett I have another PR ready to be submitted which fixes a bug in borderRadius and which has WPF part updated too. Is it okay if you approve this PR and I will do the Playground screenshots and code as part of the next PR?
There was a problem hiding this comment.
I'd prefer to see a contribution upstream for a border*Radius example in RNTester. Does not need to be done for this repo.
There was a problem hiding this comment.
ReactNative already has examples of border*Radius at https://github.com/facebook/react-native/edit/master/RNTester/js/BorderExample.js see styles border6, border9, border10, border14.
| /// Enum values correspond to positions of prop names in ReactPropGroup attribute | ||
| /// applied to <see cref="SetBorderRadius(Border, int, double)"/> | ||
| /// </summary> | ||
| private enum Radius |
There was a problem hiding this comment.
BEGIN NITPICK
In general I don't know why we add private enums when ints work just fine.
END NITPICK
…ly border radius props to ReactImageManager