Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] [BUGFIX] [Cocoapods integration ]Fixing error when using RCTAnimation in Swift project using cocoapods #20963

Closed
wants to merge 1 commit into from

Conversation

barrault01
Copy link

@barrault01 barrault01 commented Sep 4, 2018

Hello,

When you try to install React Native with RCTAnimation dependency using Cocoapods on an existing swift project, it does not compile.

This PR fixed the problem explained in this issue :#13198.

The solution was already presented here: #13198 but never implemented.

Test Plan:

Clone this project that demonstrate the bug : https://github.com/barrault01/swift-reactnative.git

git clone https://github.com/barrault01/swift-reactnative.git
yarn install
cd ios
pod install
open ReatNativeSwift.xcworkspace 

To fix the bug update the version of react-native on the package.json

{
  "name": "MyReactNativeApp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start"
  },
  "dependencies": {
    "react": "16.4.1",
    "react-native": "git://github.com/barrault01/react-native.git#70f7e5ea9ed226604d795b6646f14a8192b860fb"
  }
}

Then run do this again on the root folder of the project:

yarn install
cd ios
pod install
open ReatNativeSwift.xcworkspace 

And now the build will sucessed.

Release Notes:

[iOS] [BUGFIX] [Cocoapods integration] - now using RCTAnimation subspecs does not make the build failed on iOS when integrated React Native using Cocoapods.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

pull-bot commented Sep 4, 2018

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot added Platform: iOS iOS applications. Missing Test Plan This PR appears to be missing a test plan. labels Sep 4, 2018
@barrault01 barrault01 changed the title [iOS] [BUGFIX] [ {Cocoapods integration} ]Fixing error when using RCTAnimation in Swift project using cocoapods [iOS] [BUGFIX] [Cocoapods integration ]Fixing error when using RCTAnimation in Swift project using cocoapods Sep 4, 2018
@barrault01
Copy link
Author

I made a similar PR here : #20964

@barrault01 barrault01 closed this Sep 4, 2018
@barrault01 barrault01 reopened this Sep 6, 2018
@barrault01
Copy link
Author

I reopened this pull request due to the fact very PRs should be on to of master branch.

@ikesyo
Copy link
Contributor

ikesyo commented Sep 6, 2018

I believe #18050 is more appropriate fix and @hramos started importing it before (but failed).

@barrault01
Copy link
Author

@ikesyo I give a look @ #18050 and try the fixe locally, it works with cocoapods and when using Xcode integration. The fact that the cocoapods integration is not working is really breaking our workflow. What can I do to help making this PR #18050 go inside the next release?

@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. and removed Missing Test Plan This PR appears to be missing a test plan. labels Sep 6, 2018
@ikesyo
Copy link
Contributor

ikesyo commented Sep 11, 2018

#18050 has been merged, so this can be closed.

@barrault01
Copy link
Author

Yep :)

@barrault01 barrault01 closed this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants