Correct RCTAnimation import #18050

LukeDurrant · 2018-02-22T01:07:56Z

Motivation

Fixing error
node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: 'RCTAnimation/RCTValueAnimatedNode.h' file not found

I'm integrating react native into an existing app through cocoa pods and similar to other PRs
PR #16192
PR #16271
PR #17764
When integrating with cocoa pods

pod 'React', :path => './node_modules/react-native', :subspecs => [
    'Core',
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTText',
    'RCTNetwork',
    'RCTWebSocket', # needed for debugging
    'RCTImage',
    'RCTWebSocket',
    'BatchedBridge',
    'RCTLinkingIOS',
    'RCTActionSheet',
    'RCTAnimation'
    ]

With RCTAnimation being the important part for this PR.

Also note without this PR and the other PR's above if anyone is trying to integrate react native into an existing app i.e. through cocoa pods they won't be able too. I think the latest working version is

Test Plan

My app wouldn't build without changing this line

Related PRs

PR #16192
PR #16271
PR #17764

Release Notes

[IOS] [BREAKING] [PODS] - Fixed RCTAnimation import for integrating with cocoapods

facebook-github-bot · 2018-02-22T01:08:10Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

janicduplessis

Sadly this breaks normal xcode build (you can see the error on CI). Maybe it would work if we change the copy headers phase of RCTAnimation.xcodeproj to copy to the React/ folder instead of RCTAnimation/

LukeDurrant · 2018-02-26T00:59:59Z

~~Appears the RCTAnimation.xcodeproj doesn't build before this PR as well..~~
Looked further into how the CI tests are running and theres a RNTester project that you have to open

LukeDurrant · 2018-02-26T02:20:25Z

I think maybe a better solution is to move the correct files to make the correct files public in the Header Phase. See if this fixes the tests and allows cocoa pods integration

facebook-github-bot · 2018-02-26T07:30:11Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

janicduplessis · 2018-03-01T23:35:49Z

@LukeDurrant Were you able to get it to build locally without cocoapods? Looks like CI is still failing :(

I do like this approach though.

LukeDurrant · 2018-03-05T03:44:23Z

No can't get it to work in both

msand · 2018-03-10T00:03:36Z

This should probably be solved using this approach: #13198 (comment)

facebook-github-bot · 2018-03-28T17:05:42Z

@LukeDurrant I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

LukeDurrant · 2018-04-11T14:00:36Z

Sorry looks like a few people got notified for review, rebased to the wrong branch and made lots of proposed file changes

LukeDurrant · 2018-04-11T14:04:33Z

Appears ebd12fa has broken all the tests... unsure why this was even merged..

facebook-github-bot · 2018-05-11T17:05:20Z

@LukeDurrant I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

…issues

hramos · 2018-05-14T16:54:03Z

Does the PR description need to be updated?

LukeDurrant · 2018-05-15T00:30:16Z

No different solution to the same problem react native doesn’t build when integrating using cocopods

facebook-github-bot · 2018-06-12T17:05:30Z

@LukeDurrant I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

vovkasm · 2018-06-18T22:34:09Z

I think current diff should work with CocoaPods and Xcode integration variants. Personally I tested this changeset with CocoaPods variant and it works.

Can I help further to make this change landed?

soranoba · 2018-07-25T17:52:24Z

What is the status of this PR?
I believe that this fix is correct, and I'm hoping for an early solution.

I think that import seems to be successful from the error of CI.
Will not it be resolved by rebase or retest?

facebook-github-bot

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ikesyo · 2018-09-06T10:38:36Z

@hramos Could you please retry to import this?

Summary: Fixing error node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: 'RCTAnimation/RCTValueAnimatedNode.h' file not found I'm integrating react native into an existing app through cocoa pods and similar to other PRs PR #16192 PR #16271 PR #17764 When integrating with cocoa pods ``` pod 'React', :path => './node_modules/react-native', :subspecs => [ 'Core', 'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43 'RCTText', 'RCTNetwork', 'RCTWebSocket', # needed for debugging 'RCTImage', 'RCTWebSocket', 'BatchedBridge', 'RCTLinkingIOS', 'RCTActionSheet', 'RCTAnimation' ] ``` With `RCTAnimation` being the important part for this PR. Also note without this PR and the other PR's above if anyone is trying to integrate react native into an existing app i.e. through cocoa pods they won't be able too. I think the latest working version is My app wouldn't build without changing this line PR #16192 PR #16271 PR #17764 [IOS] [BREAKING] [PODS] - Fixed RCTAnimation import for integrating with cocoapods Pull Request resolved: #18050 Differential Revision: D9235162 Pulled By: hramos fbshipit-source-id: 426daccf8d8952658e262d5a0e4623c72c38542c

Summary: Fixing error node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: 'RCTAnimation/RCTValueAnimatedNode.h' file not found I'm integrating react native into an existing app through cocoa pods and similar to other PRs PR facebook#16192 PR facebook#16271 PR facebook#17764 When integrating with cocoa pods ``` pod 'React', :path => './node_modules/react-native', :subspecs => [ 'Core', 'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43 'RCTText', 'RCTNetwork', 'RCTWebSocket', # needed for debugging 'RCTImage', 'RCTWebSocket', 'BatchedBridge', 'RCTLinkingIOS', 'RCTActionSheet', 'RCTAnimation' ] ``` With `RCTAnimation` being the important part for this PR. Also note without this PR and the other PR's above if anyone is trying to integrate react native into an existing app i.e. through cocoa pods they won't be able too. I think the latest working version is My app wouldn't build without changing this line PR facebook#16192 PR facebook#16271 PR facebook#17764 [IOS] [BREAKING] [PODS] - Fixed RCTAnimation import for integrating with cocoapods Pull Request resolved: facebook#18050 Differential Revision: D9235162 Pulled By: hramos fbshipit-source-id: 426daccf8d8952658e262d5a0e4623c72c38542c

LukeDurrant requested a review from janicduplessis as a code owner February 22, 2018 01:07

Plo4ox mentioned this pull request Feb 23, 2018

Fix - Unable to build React target after a 'pod install' #17764

Closed

janicduplessis suggested changes Feb 24, 2018

View reviewed changes

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Feb 26, 2018

sdwilsh removed the cla signed label Mar 1, 2018

msand mentioned this pull request Mar 9, 2018

[iOS][cocoapods] 'RCTAnimation/RCTValueAnimatedNode.h' file not found #13198

Closed

hramos added the Platform: iOS iOS applications. label Mar 13, 2018

LukeDurrant force-pushed the task/animate-header branch 2 times, most recently from 82b84cd to 3b7a15d Compare April 11, 2018 13:35

LukeDurrant requested review from grabbou, hramos, Kureev, mhorowitz and shergin as code owners April 11, 2018 13:35

LukeDurrant force-pushed the task/animate-header branch 2 times, most recently from 3f8a82d to e66d28d Compare April 11, 2018 13:57

This was referenced Apr 11, 2018

Task/test cocoapods fixes #18810

Closed

Include Fishhook with check #18811

Closed

Don’t import RCTValueAnimatedNode at all… caused cocopod integration …

73a8aa2

…issues

LukeDurrant force-pushed the task/animate-header branch from e66d28d to 73a8aa2 Compare May 13, 2018 03:14

vovkasm added a commit to vovkasm/react-native that referenced this pull request Jun 5, 2018

Incorporate patch from facebook#18050 - Correct RCTAnimation import

b3ff25a

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 9, 2018

facebook-github-bot approved these changes Aug 9, 2018

View reviewed changes

ikesyo mentioned this pull request Sep 6, 2018

[iOS] [BUGFIX] [Cocoapods integration ]Fixing error when using RCTAnimation in Swift project using cocoapods #20963

Closed

hramos added the 🕐PR Waiting on FB label Sep 6, 2018

hramos mentioned this pull request Sep 11, 2018

0.57.0 Discussion react-native-community/releases#34

Closed

facebook-github-bot closed this in eef8d47 Sep 11, 2018

LukeDurrant deleted the task/animate-header branch September 12, 2018 00:32

hramos added Needs: Imported Diff Waiting on Meta and removed Waiting for FB labels Jan 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct RCTAnimation import #18050

Correct RCTAnimation import #18050

LukeDurrant commented Feb 22, 2018

facebook-github-bot commented Feb 22, 2018

janicduplessis left a comment

LukeDurrant commented Feb 26, 2018 •

edited

Loading

LukeDurrant commented Feb 26, 2018

facebook-github-bot commented Feb 26, 2018

janicduplessis commented Mar 1, 2018

LukeDurrant commented Mar 5, 2018

msand commented Mar 10, 2018

facebook-github-bot commented Mar 28, 2018

LukeDurrant commented Apr 11, 2018

LukeDurrant commented Apr 11, 2018

facebook-github-bot commented May 11, 2018

hramos commented May 14, 2018

LukeDurrant commented May 15, 2018

facebook-github-bot commented Jun 12, 2018

vovkasm commented Jun 18, 2018

soranoba commented Jul 25, 2018

facebook-github-bot left a comment

ikesyo commented Sep 6, 2018

Correct RCTAnimation import #18050

Correct RCTAnimation import #18050

Conversation

LukeDurrant commented Feb 22, 2018

Motivation

Test Plan

Related PRs

Release Notes

facebook-github-bot commented Feb 22, 2018

janicduplessis left a comment

Choose a reason for hiding this comment

LukeDurrant commented Feb 26, 2018 • edited Loading

LukeDurrant commented Feb 26, 2018

facebook-github-bot commented Feb 26, 2018

janicduplessis commented Mar 1, 2018

LukeDurrant commented Mar 5, 2018

msand commented Mar 10, 2018

facebook-github-bot commented Mar 28, 2018

LukeDurrant commented Apr 11, 2018

LukeDurrant commented Apr 11, 2018

facebook-github-bot commented May 11, 2018

hramos commented May 14, 2018

LukeDurrant commented May 15, 2018

facebook-github-bot commented Jun 12, 2018

vovkasm commented Jun 18, 2018

soranoba commented Jul 25, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

ikesyo commented Sep 6, 2018

LukeDurrant commented Feb 26, 2018 •

edited

Loading