Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standalone for NativeComponents] RCTMaskedView #23001

Closed
wants to merge 1 commit into from
Closed

[Standalone for NativeComponents] RCTMaskedView #23001

wants to merge 1 commit into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Jan 15, 2019

This pull request is part of #22990.

Changelog:

[iOS] [Changed] - Split RCTMaskedView into RCTMaskedViewNativeComponent.

Test Plan:

  • npm run lint
  • npm run flow-check-ios
  • npm run flow
  • npm run test
  • npm run build-ios-e2e
  • npm run test-ios-e2e

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2019
@nissy-dev nissy-dev mentioned this pull request Jan 15, 2019
Closed
5 tasks
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 16, 2019
facebook-github-bot
facebook-github-bot approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite elicwhite self-assigned this Jan 16, 2019
@react-native-bot
Copy link
Collaborator

@Leko merged commit d0ba9ce into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 16, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 16, 2019
@elicwhite
Copy link
Member

Thanks for contributing!

@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@Leko @facebook-github-bot
RCTMaskedView (facebook#23001)
cd7b0ec 
Summary:
This pull request is part of facebook#22990.

Changelog:
----------

[iOS] [Changed] - Split RCTMaskedView into RCTMaskedViewNativeComponent.
Pull Request resolved: facebook#23001

Differential Revision: D13697245

Pulled By: TheSavior

fbshipit-source-id: 16af0b394ae32cd3c4992c2cd5ea2d3c140755b3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees

@elicwhite elicwhite

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Leko @react-native-bot @elicwhite @facebook-github-bot @hramos