ReactEditText extends AppCompatEditText

[dulmandakh]

Summary

Google recommends to extend AppCompat widgets, and this PR changes ReactEditText to extend AppCompatEditText.

Changelog

[Android] [Changed] - ReactEditText extends AppCompatEditText

Test Plan

CI is green, and everything works as before.

[pull-bot]

	Warnings
⚠️	📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Thank you!

[dulmandakh]

@cpojer is there anything I can help with?

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[hey99xx]

You may want to test this with old Android OS like API 19.

Earlier I found some AppCompat widgets wrap the original context, making any (ReactContext) getContext() throws

java.lang.ClassCastException: android.support.v7.widget.TintContextWrapper cannot be cast to com.facebook.react.bridge.ReactContext`

I see couple dangerous getContext usages that way in ReactEditText class, and AppCompatEditText is one of those widgets that wraps its context:

https://github.com/aosp-mirror/platform_frameworks_support/blob/support-library-27.1.0/v7/appcompat/src/main/java/android/support/v7/widget/AppCompatEditText.java#L64

See #22885 (comment) was fixed in 58437cd In some of these PRs you may need to do something similar or find better way to keep hold of context.

[dulmandakh]

@hey99xx We cannot stick to platform widgets forever, even they are getting deprecated. What would be a generic solution for this?

[dulmandakh]

@hey99xx quick google search reveals that it can be solved if we extend AppCompatActivity. So I think it'll gone once 0.59 released with ReactActivity extending AppCompatActivity. Is that true?

[hey99xx]

I dont know why activity class matters for casting context. In support library code that wraps the context with TintContextWrapper only api version is checked, not activity type. I have two suggestion for you:

---

(1) We can either have a generic method that does the context unwrapping done in 58437cd like

public static ReactContext getReactContext(View view) { ... }

then when we need to get the context

@Override
public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
-  ReactContext reactContext = (ReactContext) getContext();
+  ReactContext reactContext = ReactContextHelper.getReactContext(this);

---

(2) or we save the ReactContext as variable when we know it'll be used again:

+final ReactContext mReactContext;

-public ReactEditText(Context context) {
-  super(context);
+public ReactEditText(ReactContext context) {
+  super(context);
+  mReactContext = context;

@Override
public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
- ReactContext reactContext = (ReactContext) getContext();
  InputConnection inputConnection = super.onCreateInputConnection(outAttrs);
  if (inputConnection != null && mOnKeyPress) {
-   inputConnection = new ReactEditTextInputConnectionWrapper(inputConnection, reactContext, this);
+   inputConnection = new ReactEditTextInputConnectionWrapper(inputConnection, mReactContext, this);
  }

---

I prefer 2nd as it's cleaner, and you don't need to worry about which context class wraps which in the future.

[hey99xx]

Btw platform widgets like EditText is not getting deprecated. AppCompatEditText is a subclass of EditText that's documented as

A EditText which supports compatible features on older versions of the platform, ...

As I understand, AppCompat widgets only add value for old Android versions to make app look consistent with modern Android versions, as also mentioned in original checkbox PR #18318. So I support your PRs like this, just make sure you test it :)

[dulmandakh]

@hey99xx I target M for my current project, because we've been experiencing many issues/inconsistencies on Android versions below. Recently, I found that RN use many APIs that are not available in Android 4.x, and I think the solution might be more use of Support Library. Thank you.

[dulmandakh]

@cpojer @mdvacca please review and merge 👍

[hey99xx]

Aren't setIntrinsicContentSize and onCreateInputConnection crash on lower API versions after this?