Use latest React Native CLI #24517
Closed
Use latest React Native CLI #24517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
I feel like `commands` at the beginning just reads nicer.
thymikee
approved these changes
Apr 19, 2019
gengjiawen
approved these changes
Apr 19, 2019
|
Let's merge it so it unblocks #24506 |
4 tasks
Salakar
reviewed
Apr 22, 2019
facebook-github-bot
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @cpojer!
We will need to update the CLI dependency one more time, but RNTester works
w/o issues on master now, so that's good!
…On Tue, 23 Apr 2019 at 11:15, Facebook Community Bot < ***@***.***> wrote:
***@***.**** approved this pull request.
@cpojer <https://github.com/cpojer> is landing this pull request. If you
are a Facebook employee, you can view this diff on Phabricator
<https://phabricator.internmc.facebook.com/D15044762>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24517 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASZZRSRS3FSNMDRUHD7YM3PR3HS3ANCNFSM4HHAOMUA>
.
|
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @grabbou in 706f67a. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2019
Summary: Replaces #24099 (original PR became detached for some reason) Implements the template changes required to enable native modules auto-linking for both Android & iOS. Requires the following to be merged first and an updated CLI to be published: - [x] react-native-community/cli#254 - [x] react-native-community/cli#256 - [x] react-native-community/cli#258 cc grabbou thymikee orta for review - [ ] #24517 update CLI version) [TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects Pull Request resolved: #24506 Differential Revision: D15062701 Pulled By: cpojer fbshipit-source-id: 65296cbec2925405fe8033de71910325e0c719bc
kelset
pushed a commit
that referenced
this pull request
Jun 19, 2019
Summary: Replaces #24099 (original PR became detached for some reason) Implements the template changes required to enable native modules auto-linking for both Android & iOS. Requires the following to be merged first and an updated CLI to be published: - [x] react-native-community/cli#254 - [x] react-native-community/cli#256 - [x] react-native-community/cli#258 cc grabbou thymikee orta for review - [ ] #24517 update CLI version) [TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects Pull Request resolved: #24506 Differential Revision: D15062701 Pulled By: cpojer fbshipit-source-id: 65296cbec2925405fe8033de71910325e0c719bc # Conflicts: # template/ios/Podfile
|
We are maintaining react-native project within android (the classical way) and we were soo much dependent on --reactNativePath for our build process. Now after migrating from 0.59 -> 0.61.5 we are not finding a way to provide --reactNativePath. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates React Native to use latest CLI.
Changes:
--reactNativePath, define it once in the configuration file. This reverts the previous PR that added this flagplatformsandcommands- React Native now defines platform like any other package. There's no longer concept of "out-of-tree" platform. All are treated equally. If React Native works, any other platform will work too.jest/hasteImpl.jsto use public CLI interface (loadConfig) instead offindPluginsand removes a weird conditional that checks for CI presence.Changelog
[INTERNAL] - Update React Native CLI
Test Plan
Run RNTester and it works