[template] Implement changes to enable native modules auto linking #24506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/auto-init # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
facebook-github-bot
added
the
CLA Signed
Salakar
changed the title
|
Salakar
added
Platform: Android
orta
reviewed
Apr 18, 2019
Salakar
changed the title
cpojer
approved these changes
Apr 24, 2019
facebook-github-bot
approved these changes
Apr 24, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @Salakar in 261197d. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 13, 2019
Summary: The iOS End-to-End tests started failing with the updates made to the iOS template's Podfile in 261197d. Undoing these gets our CI iOS e2e test step back to green. [iOS] [Removed] - Revert auto-linking related changes to the iOS template Podfile Pull Request resolved: #24788 Differential Revision: D15317895 Pulled By: cpojer fbshipit-source-id: a1f3b84b39c6d341740f742d83fd05a1ab841184
kelset
pushed a commit
that referenced
this pull request
Jun 19, 2019
Summary: Replaces #24099 (original PR became detached for some reason) Implements the template changes required to enable native modules auto-linking for both Android & iOS. Requires the following to be merged first and an updated CLI to be published: - [x] react-native-community/cli#254 - [x] react-native-community/cli#256 - [x] react-native-community/cli#258 cc grabbou thymikee orta for review - [ ] #24517 update CLI version) [TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects Pull Request resolved: #24506 Differential Revision: D15062701 Pulled By: cpojer fbshipit-source-id: 65296cbec2925405fe8033de71910325e0c719bc # Conflicts: # template/ios/Podfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #24099 (original PR became detached for some reason)
Implements the template changes required to enable native modules auto-linking for both Android & iOS.
Requires the following to be merged first and an updated CLI to be published:
cc @grabbou @thymikee @orta for review
Depends on
Changelog
[TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects
Test Plan