[CI][test_end_to_end] Partially back out #24506, fixing iOS e2e tests #24788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramos
referenced
this pull request
May 9, 2019
Summary: Replaces #24099 (original PR became detached for some reason) Implements the template changes required to enable native modules auto-linking for both Android & iOS. Requires the following to be merged first and an updated CLI to be published: - [x] react-native-community/cli#254 - [x] react-native-community/cli#256 - [x] react-native-community/cli#258 cc grabbou thymikee orta for review - [ ] #24517 update CLI version) [TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects Pull Request resolved: #24506 Differential Revision: D15062701 Pulled By: cpojer fbshipit-source-id: 65296cbec2925405fe8033de71910325e0c719bc
facebook-github-bot
added
CLA Signed
|
We need @grabbou's knowledge on testing infra here. Let's wait for him to chime in |
|
I am fine with merging this PR. We were not planning to turn on auto-linking by default before it gets stable. I guess we can do another PR where we turn it on and explicitly test the CI once again. |
cpojer
approved these changes
May 13, 2019
facebook-github-bot
approved these changes
May 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @hramos in da7d3df. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The iOS End-to-End tests started failing with the updates made to the iOS template's Podfile in 261197d. Undoing these gets our CI iOS e2e test step back to green.
Changelog
[iOS] [Removed] - Revert auto-linking related changes to the iOS template Podfile
Test Plan
test_end_to_endis still red, but the individual "iOS End-to-End" step is now green: https://circleci.com/gh/hramos/react-native/5659