Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename autolinking-ios.rb script and bring RNTester and template in line. #28073

Closed
wants to merge 5 commits into from

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Feb 14, 2020

Summary

Make the script ready for picking in 0.62.0-rc.3.

  • Rename the script to remove ambiguity. “autolinking” is a CLI feature where 3rd-party pods are automatically discovered: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
  • Make the Flipper version of the pods configurable, as requested here.
  • Make RNTester’s Podfile use the same form as the template–including enabling Flipper by moving the CPP define into the right place in the Xcode project and out of the Podfile.
  • Get rid of Podfile.lock thrashing by making the default CDN spec source explicit.

Changelog

[iOS] [Changed] - Disambiguate autolinking-ios.rb script from CLI’s “autolinking” feature and bring RNTester & template in line.

Test Plan

RNTester builds, as does a new application.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2020
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Feb 14, 2020
scripts/react_native_pods.rb Outdated Show resolved Hide resolved
@alloy
Copy link
Contributor Author

alloy commented Feb 14, 2020

Hmm, I see that I accidentally pushed this to the Facebook remote, my bad. I’ll configure my checkout to default to my fork for next time.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite
Copy link
Member

Can you rebase on top of master? I got some merge conflicts when importing. Looks like one of these files may have been changed since

@alloy
Copy link
Contributor Author

alloy commented Feb 14, 2020

Can’t force push to this branch on the fb repo, so created a new PR from my fork #28077

@alloy alloy closed this Feb 14, 2020
@hramos hramos deleted the ios-link-rn-pods-improvements branch February 19, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants