Smoothen Flipper iOS integration #28044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Flipper’s dependencies don’t all come with bitcode. See: facebook#27565 (comment)
alloy
force-pushed
the
smoothen-flipper-ios-integration
branch
from
a888a75
to
50ee76d
Compare
alloy
commented
Feb 13, 2020
| [client addPlugin:[FlipperKitReactPlugin new]]; | ||
| [client addPlugin:[[FlipperKitNetworkPlugin alloc] initWithNetworkAdapter:[SKIOSNetworkAdapter new]]]; | ||
| [client start]; | ||
| } |
There was a problem hiding this comment.
Grouping this up here so users that upgrade don’t need to add snippets of code through the file too much.
alloy
commented
Feb 13, 2020
| installer.pods_project.save | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Make it easier for users to upgrade.
facebook-github-bot
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @alloy in 619d5d6. When will my fix make it into a release? | Upcoming Releases |
|
|
||
| def add_flipper_pods! |
There was a problem hiding this comment.
@alloy Should we allow passing the flipper version here to override the default one, this would allow updating flipper independently of RN.
There was a problem hiding this comment.
Ah yes, good call; I had wanted to do that but clearly forgot, thanks!
There was a problem hiding this comment.
(Won’t make it for RC 3, but the next release.)
alloy
added a commit
that referenced
this pull request
Feb 13, 2020
Summary: Addresses my feedback [here](#27565 (comment)), [here](#27565 (comment)), and [here](#27565 (comment)). ## Changelog [iOS] [Changed] - Updated Flipper iOS integration to be included by default in the `Debug` configuration Pull Request resolved: #28044 Test Plan: Manually tested that a new application from this template still works and that the Flipper integration works. <img width="912" alt="Screenshot 2020-02-13 at 02 09 42" src="https://user-images.githubusercontent.com/2320/74391951-eb6fd800-4e05-11ea-9fde-7e0eb42c1ec4.png"> Differential Revision: D19871482 Pulled By: TheSavior fbshipit-source-id: a805808fdd0c2dfdfe47dd59ffee02c81f3fdfa7
This was referenced Feb 14, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 19, 2020
…ine. (#28077) Summary: Make the script ready for picking in 0.62.0-rc.3. * Rename the script to remove ambiguity. “autolinking” is a CLI feature where 3rd-party pods are automatically discovered: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md * Make the Flipper version of the pods configurable, as requested [here](#28044 (comment)). * Make RNTester’s Podfile use the same form as the template–including enabling Flipper by moving the CPP define into the right place in the Xcode project and out of the Podfile. * Get rid of Podfile.lock thrashing by making the default CDN spec source explicit. ## Changelog [iOS] [Changed] - Disambiguate autolinking-ios.rb script from CLI’s “autolinking” feature and bring RNTester & template in line. Pull Request resolved: #28077 Test Plan: RNTester builds, as does a new application. Reviewed By: PeteTheHeat Differential Revision: D19956392 Pulled By: TheSavior fbshipit-source-id: 6c800ddb646b49fc45c088978e2794cd7b60ea48
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Addresses my feedback [here](facebook#27565 (comment)), [here](facebook#27565 (comment)), and [here](facebook#27565 (comment)). ## Changelog [iOS] [Changed] - Updated Flipper iOS integration to be included by default in the `Debug` configuration Pull Request resolved: facebook#28044 Test Plan: Manually tested that a new application from this template still works and that the Flipper integration works. <img width="912" alt="Screenshot 2020-02-13 at 02 09 42" src="https://user-images.githubusercontent.com/2320/74391951-eb6fd800-4e05-11ea-9fde-7e0eb42c1ec4.png"> Differential Revision: D19871482 Pulled By: TheSavior fbshipit-source-id: a805808fdd0c2dfdfe47dd59ffee02c81f3fdfa7
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
…ine. (facebook#28077) Summary: Make the script ready for picking in 0.62.0-rc.3. * Rename the script to remove ambiguity. “autolinking” is a CLI feature where 3rd-party pods are automatically discovered: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md * Make the Flipper version of the pods configurable, as requested [here](facebook#28044 (comment)). * Make RNTester’s Podfile use the same form as the template–including enabling Flipper by moving the CPP define into the right place in the Xcode project and out of the Podfile. * Get rid of Podfile.lock thrashing by making the default CDN spec source explicit. ## Changelog [iOS] [Changed] - Disambiguate autolinking-ios.rb script from CLI’s “autolinking” feature and bring RNTester & template in line. Pull Request resolved: facebook#28077 Test Plan: RNTester builds, as does a new application. Reviewed By: PeteTheHeat Differential Revision: D19956392 Pulled By: TheSavior fbshipit-source-id: 6c800ddb646b49fc45c088978e2794cd7b60ea48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses my feedback here, here, and here.
Changelog
[iOS] [Changed] - Updated Flipper iOS integration to be included by default in the
DebugconfigurationTest Plan
Manually tested that a new application from this template still works and that the Flipper integration works.