[HOLD] [iOS] Add --enabler-flipper
flag
#958
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As mentioned here, this makes it so there’s a clearer way to control whether or not to compile Flipper client in the user’s application.
This will set the
FB_FLIPPER_ENABLED
andFB_SONARKIT_ENABLED
CPP definitions to1
, which, with the default RN template will compile the flipper bits in.Depends on this change: alloy/react-native@ae4f936
Test Plan:
The right
xcodebuild
command is invoked:…and indeed the application only shows up in Flipper desktop when it’s enabled.