fix: remove unactionable warning when on 'Paper' #33830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Base commit: d7921f0 |
cortinico
reviewed
May 13, 2022
Comment on lines
+38
to
+41
| const errorMessage = | ||
| "Native Component '" + | ||
| componentName + | ||
| "' that calls codegenNativeComponent was not code generated at build time. Please check its definition."; |
There was a problem hiding this comment.
Thanks for sending this over @tido64
I'm unsure this is the correct fix. Let me loop this internally.
There was a problem hiding this comment.
This looks like safe to land. @fortmarek we should cherry-pick this for the next RC 👍
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @tido64 in 494b73c. When will my fix make it into a release? | Upcoming Releases |
fortmarek
pushed a commit
that referenced
this pull request
May 20, 2022
Summary: We are currently seeing warning `Native Component 'X' that calls codegenNativeComponent was not code generated at build time. Please check its definition.` even though we have not opted into Fabric. This warning is not actionable and is just noisy. See also discussion: reactwg/react-native-releases#21 (comment) ## Changelog [General] [Fixed] - Remove unactionable warning about `codegenNativeComponent` when on 'Paper' Pull Request resolved: #33830 Test Plan: n/a Reviewed By: dmitryrykun Differential Revision: D36377844 Pulled By: cortinico fbshipit-source-id: 23c9f9dbf0ce1cea60c5dc8caa02d0dc53bd635d
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are currently seeing warning
Native Component 'X' that calls codegenNativeComponent was not code generated at build time. Please check its definition.even though we have not opted into Fabric. This warning is not actionable and is just noisy.See also discussion: reactwg/react-native-releases#21 (comment)
Changelog
[General] [Fixed] - Remove unactionable warning about
codegenNativeComponentwhen on 'Paper'Test Plan
n/a