Replies: 42 comments 211 replies
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
I do not believe statements like that are relevant for this issue? |
Beta Was this translation helpful? Give feedback.
-
|
It will support RN 0.68.1 https://blog.expo.dev/expo-sdk-45-beta-is-now-available-88507051f6d2 @wibb36 |
Beta Was this translation helpful? Give feedback.
-
|
@wibb36 this section has nothing to do with expo, if you want to discuss you can start a thread on https://github.com/expo/expo/discussions Here the discussion should be limited to RN 0.69 release process. Expo team & react native team work independently. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Hey @leotm, thanks for the heads-up - updated 👍 |
Beta Was this translation helpful? Give feedback.
-
|
FYI, the contribution related content is slowly moving to the React Native website, and will be removed from the wiki in the future. The matrix which this link refers to is now avaible here: |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for pointing that out @Simek, I created a PR for the minor release instructions. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
With a nice deeplink from @wjaykim this is narrowed down to this line here in react-native-community/cli / cli-config package, it's an incorrect schema validation - I'll follow it up in that repo but it will need a CLI release and dependency bump here to fix if I recall process correctly: heads up for incoming PR @grabbou / @thymikee (collaborators on the commit) :-) (scriptPhases may be a string or an object, not just a string, previously it was joi-validated to object type, now it is string type so anyone using ios script phases that are fully-specified as opposed to just a script path - will fail to build on 0.69.0) |
Beta Was this translation helpful? Give feedback.
-
|
Start of a PR here but I couldn't quite make it work, I begged for help on the PR from someone better at CLI to maybe finish 🙏 ? react-native-community/cli#1611 |
Beta Was this translation helpful? Give feedback.
-
|
PR landed with @thymikee help 🙇 react-native-community/cli@5ac83d8 - I think the next step to resolve this here is a CLI release then a version bump here to ingest it? |
Beta Was this translation helpful? Give feedback.
-
|
This one landed in v8.0.1. Will apply when lock file is regenerated or for all new projects |
Beta Was this translation helpful? Give feedback.
-
|
I just realized I had not confirmed this fix, but this was fixed by Michal - confirmed working for me - and may be considered resolved @fortmarek |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
This does seem to be new - it has been introduced here. I'd think the warning should only be raised when Fabric is enabled - for Paper, the warning is not relevant. |
Beta Was this translation helpful? Give feedback.
-
|
@cortinico: Can we remove it? This is not actionable when you're on Paper. It's just noise. |
Beta Was this translation helpful? Give feedback.
-
|
I don't know if it's related but a while back I asked for a more global way of removing log / warn. react-native-community/discussions-and-proposals#308. This could also be an option ? |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Added to the list of commits to cherry-pick, thanks @tido64 🎉 |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
great report, thanks Simon! |
Beta Was this translation helpful? Give feedback.
-
|
btw folks, did any of you benchmark also the Android side of things? new arch and old arch? (old arch should be unaffected) |
Beta Was this translation helpful? Give feedback.
-
|
0.69.0-rc.3 build times:
MacBook Pro (16-inch, 2019) |
Beta Was this translation helpful? Give feedback.
-
I had similar time to Tommy above on first install, scaled for machine speed (~69 minutes). With ccache installed and configured properly, a second "clean" run (with exception of ccache now "warm"), pod install took 6min 15sec. So with ccache now perhaps just 3min or so for Tommy's laptop and maybe 1-2mins for a new machine. The first install hurts with regard to time taken for sure but ccache helps. Now my main preoccupation is disk space. A After the build, 17GB is occupied on disk in Not sure if there are any derived artifacts from the compilation that are intermediates that may be cleared after the compile of final artifacts, but those seem to be the biggest space hogs |
Beta Was this translation helpful? Give feedback.
-
|
Hey all, We spent significant time on this issue, as the Hermes build for iOS was impacting users on both New and Old Architecture and 0.69.0-RC6 should address this. We will essentially re-use the same mechanism we were using on 0.68 on iOS while still providing a bundled version of Hermes. I'm sorry this took a little bit longer than expected (and more RCs than we hoped to), but I personally believe 0.69 was unshippable as it was before RC6 and I'm glad we took the time to address this. I'm resolving this specific thread as this was addressed, but feel free to open another if you're noticing other issues. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
this can't happen directly because of the way react-native "packs" react - there's a PR in the works by @cortinico with the details facebook/react-native-website#3092 but yeah it's likely 18.1 won't be part of 0.69. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
I raised a PR for this here. |
Beta Was this translation helpful? Give feedback.
-
Nope it was not. Thanks @fortmarek for sending the PR. Waiting for a new alpha of the CLI to land this inside RC1. |
Beta Was this translation helpful? Give feedback.
-
|
Will be picked as a part of this commit. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Hey @xiongemi The error you are seeing is most likely because support for iOS 11.0 was dropped and React Native currently supports only versions >= 12.4 (see the change here). You will need to bump your deployment target. |
Beta Was this translation helpful? Give feedback.
-
|
does that mean I have to manually change the IPHONEOS_DEPLOYMENT_TARGET? is there a way to do it automatically? every time i do a |
Beta Was this translation helpful? Give feedback.
-
|
I believe you need to change it in your Podfile, and your xcode project's info section, then they will line up correctly? |
Beta Was this translation helpful? Give feedback.
-
|
As Mike said, you should update the value in your |
Beta Was this translation helpful? Give feedback.
-
|
Let me know @xiongemi if you are still running into any issues, until then we'll consider this resolved. |
Beta Was this translation helpful? Give feedback.
-
|
Sharing this from the React Native issue tracker: We might have to look closely into this and work on a fix for it. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
It was recently removed here: react-native-community/cli@25eec7c |
Beta Was this translation helpful? Give feedback.
-
|
Given the bump in the React Native CLI as pointed out by @tido64, I'd say this issue is expected, will consider this to be resolved 🙂 |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Added to the list of picks cc @cortinico 🚀 |
Beta Was this translation helpful? Give feedback.
-
|
My apologies in advance if this is not the correct place for this but I encountered the following while upgrading to 0.69.0-rc.1. I don't mind moving this or parts of this to the correct location if needed. OS: Void Linux Not sure how useful this is but I had issues building Hermes after manually upgrading from 0.68.1 to 0.69.0-rc.1 by following https://react-native-community.github.io/upgrade-helper/?from=0.68.1&to=0.69.0-rc.0. As a side note I am also using the 0.68.1 TypeScript template. 1. The first issue was related to not enabling Hermes but it builds when the new architecture is enabled anyway. Not a huge problem as the docs above (reactwg/react-native-new-architecture#4) explain that Hermes is built with RN 0.69 and that ensures the versions are compatible. Maybe a note in the docs that this overrides the enableHermes config would prevent confusion since this is new. 2. The second issue that caused the first to be more of a confusion was that Hermes would fail to build and it was not immediately clear why as I could not find anyone else with this issue. To fix this I installed icu-devel using I figured that much out by looking at https://github.com/facebook/hermes/blob/f11379f0564fd2b93a6024debffccd5eebce547e/CMakeLists.txt#L465 and seeing that it was expecting a Maybe another note could be added to the docs for Linux users that encounter this issue as building Hermes with React Native is new to 0.69. Or maybe this is a one off issue just for me. I saw that ICU is required for building Hermes but I did not see this issue in the Hermes repository. Should the Hermes build process contain ICU or download it for systems that don't already have ICU? 3. The last issue actually occurred prior to the Hermes issues but I saved it for last as it may not be related to this discussion. I kept getting: I read on a related stack overflow question that this can be caused by having insufficient privileges but running again with sudo did not fix the issue. To fix this issue I installed mkdirp and then the Hermes issues began. I hope this is helpful. |
Beta Was this translation helpful? Give feedback.
-
|
On 2, that's an interesting point. Hermes requires ICU to build on Linux and Windows, and should automatically find ICU if it is already installed on your system. (I believe it is always available on Windows, but I may be wrong) Technically though, Hermes only needs ICU for building the VM, and not for building Concretely, there are 2 options:
|
Beta Was this translation helpful? Give feedback.
-
|
@cortinico No problem. I have never really participated in FOSS but since I felt that I ran into some new issues related to the new arch process, I figured I could share my experience. I am very appreciative of the work you guys do. To explain my documentation related notes... Much of what I found was not very difficult to solve but might cause more headaches in the future if not documented visibly. I do believe that a great deal of effort is placed on documentation and this should not be received as a complaint. I am just passing along information gathered while testing 0.69 from my perspective.
Steps I took to replicate 3:
|
Beta Was this translation helpful? Give feedback.
-
@neildhar ICU is available on all Windows 10 machines with May 2019 Update. It won't be available on Windows 7, Windows 2016 server, or a unpatched Windows 10, which are rare these days. I think we could assume ICU to be available and make sure that the requirement of having a properly patched Windows10+ OS properly documented. |
Beta Was this translation helpful? Give feedback.
-
|
I'm also having the |
Beta Was this translation helpful? Give feedback.
-
|
mkdirp has a cherry pick request below, it's already fixed on main (discovered it today myself) |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
hey Michael, I appreciate your eagerness to be on the new architecture but there's no way support for the old architecture will drop this soon. In the coming months there are going to be official blogpost detailing how and when the old architecture will stop being supported, but you can expect it to be supported for at least the rest of this year |
Beta Was this translation helpful? Give feedback.
-
|
When upgrading from 0.68.1 to 0.69.0-rc.0 got: Although the lib is apparently fine i removed it and then the same occurs but this time saying that the firebase lib could not be found in root project... |
Beta Was this translation helpful? Give feedback.
-
Knowing what's a line 48 of that file would be the bare minimum. The resources mentioned by @mikehardy would also be a valid addition 👍 |
Beta Was this translation helpful? Give feedback.
-
|
@mikehardy just: "please provide me more information" would be a kinder reply (as saying in react native terms: Showing empathy towards other community members). Im doing my best to help. The issue is that first it (0.68.1) was running fine and after the upgrade to (0.69.0-rc.0 ) following the upgrade helper now its not. I will provide more information. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @joaotmachado 👋 First off, sorry for the longer response time. Could you create a reproducible project that we could use to replicate the issue? And ideally try it with and without the third-party libraries that you are having issues with? It might be that this will need attention from the maintainers and won't be possible to fix in |
Beta Was this translation helpful? Give feedback.
-
|
FYI: Several Libs from React Native needed to manually remove folly_json and folly_futures to work with RN 0.69. Until today React Native Screens and React Native Gesture Handler need it. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @joaotmachado! Both React Native Screens and React Native Gesture Handler are aware of this. The change will make the libraries incompatible with 0.68, so the relevant PRs can only be merged once 0.69 is properly released. Thanks for the heads-up! |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
quick update here so that we don't lose track of the links: there's now a PR on the Hermes side to address this: facebook/hermes#749 the problem is that this will land in main of hermes, so how we'll get the 0.69 branch to consume this new version of Hermes with the fix needs to be determined. (is a new git tag on hermes main + bump of dep on RN side enough?) |
Beta Was this translation helpful? Give feedback.
-
|
We'll need to repeat the Hermes-related steps mentioned here and then it should be fine 👍 |
Beta Was this translation helpful? Give feedback.
-
|
ok so we need to get the new hermes tag, do |
Beta Was this translation helpful? Give feedback.
-
|
Exactly 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Marking as resolved as it's already chosen to be picked, we can reopen this thread if it's still an issue in the next RC. |
Beta Was this translation helpful? Give feedback.
-
|
question: how do you setup jest with react-native 0.69? it works fine with 0.68.2. i got an error when i try to run jest unit test: i do have this is my jest.config.js: |
Beta Was this translation helpful? Give feedback.
-
|
Hey @xiongemi 👋 Could you provide a sample project, ideally one created from the RN template from the current RC ( That being said, this does not look like a completely new issue and is most likely related to a possible misconfiguration of |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
it seems that this issue does not only apply for Hermes, Bugsnug throws the same error, edit: tried everything before posting this comment, remove node_modules and yarn.lock, delete podfile.lock, deintegrate pods, delete pods dir, delete pods cache under /Library, cleaned derived cache and reinstalled everything. edit2: during pod install there's no edit3: After adding |
Beta Was this translation helpful? Give feedback.
-
|
This is a known issue. It has been addressed in RC6. Please try again and confirm if the issue is resolved or not. |
Beta Was this translation helpful? Give feedback.
-
|
@cortinico total success for me with rc6 - 🏆 for you, @hramos and anyone else that plowed through all the hermes DX I'm just missing static frameworks support, but as we discussed while it's important to react-native-firebase (and others I'm sure, but a minority usage share I'm certain) it also doesn't have to be a blocker - I can advise people not to upgrade to 0.69 until it's working. There are no problems with 0.68.2 right now, so it's not a big issue. |
Beta Was this translation helpful? Give feedback.
-
|
@leotm @efstathiosntonas we consider this to be resolved but let us know if you still run into any issues 👀 |
Beta Was this translation helpful? Give feedback.
-
|
iOS looking good ^ i'll raise Android new issue seperately |
Beta Was this translation helpful? Give feedback.
-
|
hey. i upgrade react-native from 0.69.0-rc.3 to 0.69.0-rc.5. i got an error with the start command: i use metro version 0.71.0: any idea why? |
Beta Was this translation helpful? Give feedback.
-
|
I think you should start with |
Beta Was this translation helpful? Give feedback.
-
|
iOS with new arch looking good, some Android results below following up earlier discussion
MacBook Pro (13-inch, M1, 2020), JDK 18 aarch64 java.lang.OutOfMemoryErrorError reporting crash
java.lang.OutOfMemoryError: Failed to allocate a 320848968 byte allocation with 4742061 free bytes and 187MB until OOM, target footprint 9582429, growth limit 201326592
at java.util.Arrays.copyOf(Arrays.java:3257)
at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448)
at java.lang.StringBuilder.append(StringBuilder.java:137)
at java.lang.Throwable.toString(Throwable.java:493)
at java.lang.String.valueOf(String.java:2924)
at java.io.PrintWriter.println(PrintWriter.java:754)
at java.lang.Throwable$WrappedPrintWriter.println(Throwable.java:778)
at java.lang.Throwable.printStackTrace(Throwable.java:667)
at java.lang.Throwable.printStackTrace(Throwable.java:735)
at android.app.ApplicationErrorReport$CrashInfo.<init>(ApplicationErrorReport.java:354)
at android.app.ApplicationErrorReport$ParcelableCrashInfo.<init>(ApplicationErrorReport.java:484)
at com.android.internal.os.RuntimeInit$KillApplicationHandler.uncaughtException(RuntimeInit.java:157)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1073)
at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1068)
at java.lang.Thread.dispatchUncaughtException(Thread.java:2200)asdf |
Beta Was this translation helpful? Give feedback.
-
|
ccache looking good speeding up each run 👍 think clean post-debug/pre-release should keep the (free) disk space low while avoiding poisoned cache |
Beta Was this translation helpful? Give feedback.
-
|
i tried w Azul/Zulu 11 aarch64 but same result (should have more time this wkend for deeper dive) |
Beta Was this translation helpful? Give feedback.
-
|
@leotm I have the same MacBook as you with JDK Zulu 11 installed and all these commands work for me. |
Beta Was this translation helpful? Give feedback.
-
|
thx @sektr63a the commands build fine, just the OutOfMemoryError at runtime, figured in the end
wasn't enough, leaving openjdk 18 2022-03-22
OpenJDK Runtime Environment Zulu18.28+13-CA (build 18+37)
OpenJDK 64-Bit Server VM Zulu18.28+13-CA (build 18+37, mixed mode, sharing)and slightly deceiving
also setting Android Studio Use Gradle from: gradle-wrapper.properties from default JDK 11 to adding/setting here worked w # android/gradle.properties
# ...
org.gradle.java.home=/Users/<user>/Library/Java/JavaVirtualMachines/azul-11.0.14.1/Contents/Homebut ofc don't want that versioned for varying user/path/OS/JDK |
Beta Was this translation helpful? Give feedback.
-
|
as an aside cleaning between variants kept GitHub Actions space and exec times happy and @mikehardy ccache pretty nice locally so far, ~25% improvement w my template pre-ccache (or cleared ccache) ~4m20sSummary:
Cache directory: /Users/leo/Library/Caches/ccache
Primary config: /Users/leo/Library/Preferences/ccache/ccache.conf
Secondary config: /etc/opt/homebrew/Cellar/ccache/4.6.1_1/ccache.conf
Stats updated: Sat Jun 4 17:12:14 2022
Hits: 520 / 1036 (50.19 %)
Direct: 516 / 1084 (47.60 %)
Preprocessed: 4 / 544 (0.74 %)
Misses: 516
Direct: 568
Preprocessed: 540
Uncacheable: 373
Primary storage:
Hits: 1036 / 2144 (48.32 %)
Misses: 1108
Cache size (GB): 0.04 / 5.00 (0.83 %)
Files: 512
Cleanups: 16
Uncacheable:
Called for linking: 312
Called for preprocessing: 12
Compilation failed: 24
No input file: 1
Preprocessing failed: 24w ccache ~3mSummary:
Cache directory: /Users/leo/Library/Caches/ccache
Primary config: /Users/leo/Library/Preferences/ccache/ccache.conf
Secondary config: /etc/opt/homebrew/Cellar/ccache/4.6.1_1/ccache.conf
Stats updated: Sat Jun 4 17:17:16 2022
Hits: 777 / 1294 (60.05 %)
Direct: 773 / 1354 (57.09 %)
Preprocessed: 4 / 551 (0.73 %)
Misses: 517
Direct: 581
Preprocessed: 547
Uncacheable: 465
Primary storage:
Hits: 1550 / 2678 (57.88 %)
Misses: 1128
Cache size (GB): 0.04 / 5.00 (0.83 %)
Files: 514
Cleanups: 16
Uncacheable:
Called for linking: 390
Called for preprocessing: 14
Compilation failed: 30
No input file: 1
Preprocessing failed: 30bottlenecks atm on
edit: i got e.g. only e.g. both
|
Beta Was this translation helpful? Give feedback.
-
|
Unfortunatly, we have to DISABLE Hermes since a long time due to usage of REGEX named capture groups. Will it be available without Hermes? Thanks |
Beta Was this translation helpful? Give feedback.
-
|
I test without hermes and things seem to work fine for me. In fact, you specifically have to disable hermes in order to use static frameworks (which isn't working at the moment, but is a use case of mine) so I test that all the time as a specific thing. |
Beta Was this translation helpful? Give feedback.
-
|
incidentally looks like you can transpile your problems away with a babel plugin: facebook/react-native#32453 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Just to report that I can successfully build and run (with and without hermes ) the default template using npx react-native init RN069RC6 --version 0.69.0-rc.6 on a 2020 M1 Air 16GB (reinstalled OS from scratch, no Rosetta, latest Xcode and Android Studio) using node, watchman, yarn, cocoapods, ruby, zulu11 from homebrew (and coreutils to remove messages about missing realpath). Everything went fast and clean. Thanks to everybody for the great job. |
Beta Was this translation helpful? Give feedback.
-
|
Awesome! Thanks for testing @lfiorini |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Beta Was this translation helpful? Give feedback.
-
This is not the place to ask sadly, as this is the tracker for the React Native 0.69.x release. This is un-related to this specific release. |
Beta Was this translation helpful? Give feedback.
-
|
we would like to have these two commits in 0.69-stable for expo + swift integration when people get a chance. thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Funny, ok, will not update react-native-firebase to 15.0.0 for now |
Beta Was this translation helpful? Give feedback.
-
|
thanks @mikehardy for the great test coverage. as far as i can tell, new architecture has lots of incompatible issues for use_frameworks and flipper incompatibility is also a known issue. i would focus on regression first.
|
Beta Was this translation helpful? Give feedback.
-
|
F-D/RN-O/F-/H+: pr here facebook/react-native#34030 |
Beta Was this translation helpful? Give feedback.
-
|
Oh these are fantastic @Kudo thank you thank you! One fixes the regression (or will, once worked through) and the second enables Hermes which is a big advance. I have hope for New Architecture as well based on your notes about header structure as well, I'm sure it's just a matter of time. I really appreciate the effort here, if it was a java thing I'd be useful but on the Xcode side I'm just not too helpful other than testing+tracking @Bardiamist I think reasonable hope is that react-native-firebase v15 will work with react-native 0.69.1 - but not with flipper or new architecture. Looks like hermes and 0.69.1 may be up and running by then. Perhaps with 0.69.2 new architecture will be up, I hope so.. Unsure on flipper |
Beta Was this translation helpful? Give feedback.
-
|
for new architecture just like mentioned, the errors come from the header structure. the solution should drive by Meta IMO. there are a thousand of |
Beta Was this translation helpful? Give feedback.
-
|
We would like to have facebook/react-native#34004 merged in 0.69. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @opayen 👋 We'd like to keep the current RC act as a golden one and not add new picks there unless they relate to things specifically broken in 0.69.0. I'd currently lean to adding this in 0.69.1 instead but will keep you updated 👀 |
Beta Was this translation helpful? Give feedback.
-
|
Ok, thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Undefined symbols for architecture x86_64:
"folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::deferredReaders", referenced from:
void folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::applyDeferredReaders<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever>(unsigned int&, folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever&) in AppDelegate.o
void folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::applyDeferredReaders<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever>(unsigned int&, folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::WaitForever&, unsigned int) in AppDelegate.o
"folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::unlock()", referenced from:
std::__1::unique_lock<folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false> >::~unique_lock() in AppDelegate.o
"folly::SharedMutexImpl<false, void, std::__1::atomic, false, false, false>::~SharedMutexImpl()", referenced from:
std::__1::__shared_ptr_emplace<facebook::react::ContextContainer const, std::__1::allocator<facebook::react::ContextContainer const> >::__on_zero_shared() in AppDelegate.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
cause seems related to Flipper, remembering similar last yr 😅 defaults atm to 0.125.0 # ios/Podfile
# ...
- use_flipper!()
+ # use_flipper!()
# ...
now building/running fine
|
Beta Was this translation helpful? Give feedback.
-
|
According to the issue, it's not a regression, it was present in 0.68 under same circumstances. On those grounds, could release 0.69.0, IMHO. Continuing with my "go fever" and confirmation bias, if I understand correctly the fix is "gentle" in the sense that it is not a breaking change for people since it just deprecates one way of configuring Flipper, it does not disable it, so a 0.69.1 with facebook/react-native@0bd5239 picked doesn't seem so bad, and it could be an immediate 0.69.1-rc.0 for those affected. I'd release 0.69.0 personally otherwise it starts to get deeper into the summer where everything slows down. Idle thoughts, worth what you paid for them ;-) |
Beta Was this translation helpful? Give feedback.
-
|
If I understand the issue correctly, it only occurs when *My opinions are worth about the same as Mike's 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Hey 👋 Thanks for the report. I agree with @mikehardy that we should release 0.69.0 without the new pods script changes and then do another point release with it, given we already have other things lined up for it and this is not a new regression. |
Beta Was this translation helpful? Give feedback.
-
|
gotcha, appreciate the explanation @cipolleschi makes sense @mikehardy @tido64 (yep new arch only) sry for the false positive pick req @kelset @fortmarek 😅 should be the end of my discussion hijacking, 0.69 ftw |
Beta Was this translation helpful? Give feedback.
-
|
no worries @leotm! I think it's good to have a record here, so that when we prep up the 0.69.1 issue we can have this commit in the list of "being worthy" ;) |
Beta Was this translation helpful? Give feedback.
-
|
Hello guys. I tried to run the project on the latest version and I get crashed right away Steps to reproduce
NoteOS: Simple error
Detailed loghttps://gradle.com/s/xce3fbozvtzeg react-native info |
Beta Was this translation helpful? Give feedback.
-
|
Hey @RalissonMattias thansk for flagging this, and glad to hear everything works. For future reference, the Windows instructions are listed here: We're open to suggestions on how to improve this (i.e. I'd like to find a solution that does not rely on having to invoke command inside a VS Command Prompt). Ideally we should be able to suggest users to install just cmake, mingw and setup env variables to have everything working end-to-end. I wasn't able to find a viable solution at this stage. |
Beta Was this translation helpful? Give feedback.
-
|
Just to add that for command line only tasks there is also Visual Studio Build Tools 2022. It has the same license a VS but it is much smaller. I use this when I need only the C++ tool chain. |
Beta Was this translation helpful? Give feedback.
-
|
@cortinico @lfiorini I followed the steps in the link you sent and it worked great. I will keep testing. Some libs like react-native-screens generate errors still in the build process. Thanks, I keep the testing. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the insights @lfiorini. I will be adding this to the Hermes doc. |
Beta Was this translation helpful? Give feedback.
-
|
Just to report that following step by step the instructions above on a fresh Windows 11 box (using Build Tools 2022) I could successfully build and run npx react-native init RN069RC6 --version 0.69.0-rc.6 and npx react-native run-android but npx react-native run-windows still requires VS 2019. |
Beta Was this translation helpful? Give feedback.
-
|
Does anyone who use Mac M1 can help? As i notice the 0.69 is almost ready for launch but unfortunately we are not having success building it. Upgrading from 0.68.2 to 0.69.0-rc.6 causes the Android Build to crash when opening the App. Error message: Missing Realm constructor. Did you run "pod install"? + Info
Important Libs build.gradle npx info |
Beta Was this translation helpful? Give feedback.
-
I will do the test and get back here, although the Realm is heavily used on my project. |
Beta Was this translation helpful? Give feedback.
-
Not quite - the idea is to prove rn69 is fine on your M1 without realm, so that realm issues recieve the specific focus they need without distracting the general rn69 effort. Stated differently the assumption based on other reports from m1 users is rn69 works but realms or something else in your project has a problem. But test results beat guesses every time |
Beta Was this translation helpful? Give feedback.
-
Just tried it on a new RN69.6 project and it's working fine. Intriguing as RN68.2 > RN69.6 stops working. I'll rebuild the project from scratch and if I find anything involving the Realm, I'll report back to the community. Tks. |
Beta Was this translation helpful? Give feedback.
-
|
@joaotmachado I'm on the Realm JS team. We would love this issue created in our repo and we're looking forward to getting it resolved with you. It does look a bit like realm/realm-js#4621 though. I do see that you're working with the 10.20.0-beta.5 branch and since we're still pre building binaries and there's an ABI breaking change in the JSI header in 0.69, I would actually expect a crash when combined. We're working hard at getting a new release of our support for JSI / Hermes out, but we're seeing some breaking tests that we're currently investigating (looks to be unrelated to JSI / Hermes / React Native) 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Outstanding feedback @kraenhansen. As Realm JS being one of the top libs for RN, this information is awesome. Do you want me to create the issue? Just let me know. |
Beta Was this translation helpful? Give feedback.
-
|
How to link assets like font files to the project in RN 0.69? Now I am getting following error Here is my react-native.config.js file |
Beta Was this translation helpful? Give feedback.
-
|
Also in the thread that @mikehardy pointed out, I outlined a workaround using podspecs and Gradle scripts: oblador/react-native-vector-icons#1416 (comment). Until someone creates a generic way of handling assets, you'll have to deal with this manually unfortunately. |
Beta Was this translation helpful? Give feedback.
-
|
@waqas19921 correct, react-native-vector-icons was simply an example of the generic problem and the thread I linked had useful context which incidentally pre-answered your question I think |
Beta Was this translation helpful? Give feedback.
-
|
I haven't used |
Beta Was this translation helpful? Give feedback.
-
|
Oh that's a completely incorrect suggestion on my part then - I should have looked more closely. Looks like it needs your proposed podspec/gradle scripts style suggestions as a PR. This will potentially get pretty messy until/unless something like that module exists to pick up the CLI folks doing asset/font links though 😟 |
Beta Was this translation helpful? Give feedback.
-
|
If people are interested, I started on a script that copies assets into a user specified folder: https://github.com/microsoft/rnx-kit/blob/1a702bd0d445e21ad879a511d18dc1771069df99/packages/cli/src/copy-assets.ts#L480 Our internal setup is a bit exotic, but it could be easily expanded to generate podspecs. It's been a while since I've looked at it, but the Android part might work out of box. |
Beta Was this translation helpful? Give feedback.
-
|
I am trying to update my app to 0.69-rc6, and hit this issue: facebook/react-native#33976 Also FYI |
Beta Was this translation helpful? Give feedback.
-
Agree, though this is not a release blocker (otherwise the same would apply for every popular package in the ecosystem).
At this stage, we're only looking in issues that are letting a new project created from the new app template fail. It seems like this issue is related to some incompatibility wiht a library as no one was able to provide a reproducer with the new app template. |
Beta Was this translation helpful? Give feedback.
-
|
Looks something with Yoga in 0.69.0 |
Beta Was this translation helpful? Give feedback.
-
|
Please note that this discussion was just for the release of 0.69.0. As we did the release, you should move pick requests to #23 The one you picked is also already trakced 👍 |
Beta Was this translation helpful? Give feedback.
and others
-
2022-06-22 Update
React Native version 0.69.0 has been released (0.69.0-rc.6 has been promoted to stable) 🎉
Conversation about the patch version of 0.69.1 is happening here
The branch cut has happened.
Notice
Highlighted Changes in this release
A full detail of the release changes is available in the Changelog PR
React Native 0.69.0 will contain some significant changes that we would love to ask release testers to try.
Hermes Distribution Model
React Native 0.69.0 contains changes to how Hermes is distributed to you. The change will improve the general stability of the Engine and will make sure you're a consuming a engine that is fully compatible with a specific React Native version. This change is described here in detail.
How to test Enable Hermes following the usual instructions here https://reactnative.dev/docs/next/hermes and report any issue you're facing for Hermes in this discussion.
React 18 & Concurrent React
React Native 0.69.0 will be the first version of React Native to ship with React 18.
Users on the New Architecture, will be able to use the Concurrent React features.
By default, we're enabling Concurrent React features for users on the New Architecture.
More documentation on how to use Concurrent React within React Native can be found here.
How to test Create a React Native app enabling the New Architecture. Toggle the
concurrentRootEnabledmethod and report any issue you're facing to this discussion on the New Architecture Working Group.New Architecture
We're continuing the rollout of the New Architecture, started in React Native 0.68.
Specific issues that are related to the New Architecture should be reported inside the New Architecture Working group. If you're not a member, you can request an invite here.
Release Process
Checklist
react-native-websiteto ship new versionRetrospective Topics
Release Status
Tracking 0.69.0-rc.7
Picks for 0.69.0-rc.7
Tracking 0.69.0-rc.6
Picks for 0.69.0-rc.6
Tracking 0.69.0-rc.5
Picks for 0.69.0-rc.5
Tracking 0.69.0-rc.4
Picks for 0.69.0-rc.4
Tracking 0.69.0-rc.3
Picks for 0.69.0-rc.3
Tracking 0.69.0-rc.2
Picks for 0.69.0-rc.2
Hermes:
Tracking 0.69.0-rc.1
Blocking issues for releasing 0.69.0-rc.1
Picks for 0.69.0-rc.1
Beta Was this translation helpful? Give feedback.
All reactions