-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fontweight number value #34598
Closed
ankit-tailor
wants to merge
6
commits into
facebook:main
from
ankit-tailor:feat/fontweight-number-value
Closed
Feat/fontweight number value #34598
ankit-tailor
wants to merge
6
commits into
facebook:main
from
ankit-tailor:feat/fontweight-number-value
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
labels
Sep 5, 2022
react-native-bot
added
the
Type: Enhancement
A new feature or enhancement of an existing feature.
label
Sep 5, 2022
Base commit: 4f6929b |
Base commit: 4f6929b |
necolas
reviewed
Sep 6, 2022
74 tasks
necolas
approved these changes
Sep 6, 2022
Are there any existing unit tests that we can expand to include this change? |
No, I couldn't find any existing tests. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
todorone
reviewed
Sep 7, 2022
Co-authored-by: Fedir Ushakov <pmahotsava@gmail.com>
This pull request was successfully merged by @ankit-tailor in f1c1f81. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This PR adds support for number values for `fontWeight` as requested in facebook#34425. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Added] - Added support for number values in fontWeight. Pull Request resolved: facebook#34598 Test Plan: ```js <Text style={{ fontWeight: 900, color: 'red' }}> Hello World </Text> ``` Reviewed By: jacdebug Differential Revision: D39268920 Pulled By: cipolleschi fbshipit-source-id: 9bb711677bf173f9904b74f382659042856efd83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Type: Enhancement
A new feature or enhancement of an existing feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for number values for
fontWeight
as requested in #34425.Changelog
[General] [Added] - Added support for number values in fontWeight.
Test Plan