RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR #35101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Those CMake variables are effectively unused now. They're raising a warning on CMake builds of templates + let's not expose them as we haven't released RNGP yet, before libraries or other tools start relying on them. Changelog: [Internal] [Changed] - RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR Reviewed By: cipolleschi Differential Revision: D40751998 fbshipit-source-id: e66e17c5bbc3a53696bcb06abc5d177aee227ec3
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40751998 |
Base commit: b966d29 |
Base commit: b966d29 |
|
PR build artifact for 7da6caf is ready. |
|
PR build artifact for 7da6caf is ready. |
|
This pull request was successfully merged by @cortinico in 3f77736. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…book#35101) Summary: Pull Request resolved: facebook#35101 Those CMake variables are effectively unused now. They're raising a warning on CMake builds of templates + let's not expose them as we haven't released RNGP yet, before libraries or other tools start relying on them. Changelog: [Internal] [Changed] - RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR Reviewed By: cipolleschi Differential Revision: D40751998 fbshipit-source-id: 13f54a6247e4734c21c263f8b1e6b4b9e8ba406c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Those CMake variables are effectively unused now. They're raising a warning on CMake builds
of templates + let's not expose them as we haven't released RNGP yet, before libraries
or other tools start relying on them.
Changelog:
[Internal] [Changed] - RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR
Reviewed By: cipolleschi
Differential Revision: D40751998