Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR #35101

Closed
wants to merge 1 commit into from
Closed

RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR #35101

wants to merge 1 commit into from

Commits on Oct 27, 2022

  1. RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR 

    Summary:
Those CMake variables are effectively unused now. They're raising a warning on CMake builds
of templates + let's not expose them as we haven't released RNGP yet, before libraries
or other tools start relying on them.

Changelog:
[Internal] [Changed] - RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR

Reviewed By: cipolleschi

Differential Revision: D40751998

fbshipit-source-id: e66e17c5bbc3a53696bcb06abc5d177aee227ec3
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    7da6caf View commit details
    Browse the repository at this point in the history