Invoke closeAndReleaseSonatypeStagingRepository in the publish gradle invocation #35272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
commented
Nov 9, 2022
scripts/release-utils.js
Outdated
Comment on lines
65
to
66
| './gradlew publishAllToSonatype closeAndReleaseSonatypeStagingRepository -PisNightly=' + | ||
| isNightly, |
There was a problem hiding this comment.
@kelset IIRC, Nico was saying that this -PisNightly=' +isNightly is not required due to the check at line 61. Do you remember the same? I think I can safely remove that part of the string, WDYT?
There was a problem hiding this comment.
yeah I think it can be removed 👍
Base commit: 0376aa4 |
cipolleschi
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/close-sonatype-repo-correctly
branch
from
cd39e4c
to
19320cb
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…h gradle invocation
cipolleschi
force-pushed
the
cipolleschi/close-sonatype-repo-correctly
branch
from
19320cb
to
31672a8
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 0376aa4 |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
… invocation (facebook#35272) Summary: This PR ports back into main the changes required to properly close the SonaType repository on Maven ## Changelog [General] [Fixed] - Close the Maven repository properly Pull Request resolved: facebook#35272 Test Plan: We tested these changed in 0.71-stable branch when releasing 0.71.0-RC.0 Reviewed By: christophpurrer Differential Revision: D41154965 Pulled By: cipolleschi fbshipit-source-id: 74dd46e8fabf3baef544342282829c70d92f671f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports back into main the changes required to properly close the SonaType repository on Maven
Changelog
[General] [Fixed] - Close the Maven repository properly
Test Plan
We tested these changed in 0.71-stable branch when releasing 0.71.0-RC.0