Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dependencies): move mockfs to the right package.json #35476

Closed
wants to merge 2 commits into from
Closed

fix(dependencies): move mockfs to the right package.json #35476

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef52ba
move mockfs to the right package.json
kelset Nov 25, 2022
80fe950
move the dep to the right section
kelset Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
"metro-runtime": "0.73.3",
"metro-source-map": "0.73.3",
"mkdirp": "^0.5.1",
"mock-fs": "^5.1.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Is this should be under devDependencies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was but we have trouble in CI and in release branch due to our (improper) monorepo setup. :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah actually @jacdebug you are correct, it should be under DevDeps, let me rectify

"nullthrows": "^1.1.1",
"pretty-format": "^26.5.2",
"promise": "^8.3.0",
Expand Down
3 changes: 0 additions & 3 deletions repo-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,5 @@
"typescript": "4.1.3",
"ws": "^6.2.2",
"yargs": "^17.5.1"
},
"devDependencies": {
"mock-fs": "^5.1.4"
}
}