fix(dependencies): move mockfs to the right package.json #35476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
jacdebug
reviewed
Nov 25, 2022
package.json
Outdated
| @@ -128,6 +128,7 @@ | |||
| "metro-runtime": "0.73.3", | |||
| "metro-source-map": "0.73.3", | |||
| "mkdirp": "^0.5.1", | |||
| "mock-fs": "^5.1.4", | |||
There was a problem hiding this comment.
QQ: Is this should be under devDependencies?
There was a problem hiding this comment.
it was but we have trouble in CI and in release branch due to our (improper) monorepo setup. :(
There was a problem hiding this comment.
ah actually @jacdebug you are correct, it should be under DevDeps, let me rectify
Base commit: 319631f |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Nov 25, 2022
cortinico
approved these changes
Nov 25, 2022
|
@jacdebug can you reimport? I fixed the spot - thanks for noticing, I got confused because in -stable branch deps move around 😅 |
Base commit: 2d1d61a |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @kelset in b4fd178. When will my fix make it into a release? | Upcoming Releases |
kelset
added a commit
that referenced
this pull request
Apr 11, 2023
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: While working on 0.71 we noticed that we were hitting a "mock-fs not found" issue on CI, caused by the fact that the dependency was set in the wrong spot. This PR backports to main the fix: facebook@05646f8 & facebook@ceaebc6 This is related to the black magics of repo-config, and the fact that devDeps from repo-config don't get propagated back to the root package.json when on stable branch. Because of that, this commit doesn't NOT have a yarn.lock entry (the dep is there in main). I'm confused as to how that dep ended in the devDeps of repo config, it seems something went wrong in migrating some commits from GH to monorepo and back? check out: * facebook#34580 * facebook@f0ffd22 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - move mockfs to the right package.json Pull Request resolved: facebook#35476 Test Plan: N/A, change is transparent Reviewed By: cortinico, cipolleschi, dmytrorykun Differential Revision: D41530265 Pulled By: jacdebug fbshipit-source-id: ec7a6426d9a2a766a98a3cccc339ca7ca090c3a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on 0.71 we noticed that we were hitting a "mock-fs not found" issue on CI, caused by the fact that the dependency was set in the wrong spot.
This PR backports to main the fix: 05646f8 & ceaebc6
This is related to the black magics of repo-config, and the fact that devDeps from repo-config don't get propagated back to the root package.json when on stable branch. Because of that, this commit doesn't NOT have a yarn.lock entry (the dep is there in main).
I'm confused as to how that dep ended in the devDeps of repo config, it seems something went wrong in migrating some commits from GH to monorepo and back?
check out:
react-native.config.jsfor codegen on iOS #34580Changelog
[Internal] [Changed] - move mockfs to the right package.json
Test Plan
N/A, change is transparent