Skip to content

Commit

Permalink
fix(dependencies): move mockfs to the right package.json (#35476)
Browse files Browse the repository at this point in the history
Summary:
While working on 0.71 we noticed that we were hitting a "mock-fs not found" issue on CI, caused by the fact that the dependency was set in the wrong spot.

This PR backports to main the fix: 05646f8 & ceaebc6

This is related to the black magics of repo-config, and the fact that devDeps from repo-config don't get propagated back to the root package.json when on stable branch. Because of that, this commit doesn't NOT have a yarn.lock entry (the dep is there in main).

I'm confused as to how that dep ended in the devDeps of repo config, it seems something went wrong in migrating some commits from GH to monorepo and back?
check out:
* #34580
* f0ffd22

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Changed] - move mockfs to the right package.json

Pull Request resolved: #35476

Test Plan: N/A, change is transparent

Reviewed By: cortinico, cipolleschi, dmytrorykun

Differential Revision: D41530265

Pulled By: jacdebug

fbshipit-source-id: ec7a6426d9a2a766a98a3cccc339ca7ca090c3a0
  • Loading branch information
kelset authored and facebook-github-bot committed Nov 25, 2022
1 parent e6c0ac0 commit b4fd178
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"devDependencies": {
"flow-bin": "^0.193.0",
"hermes-eslint": "0.8.0",
"mock-fs": "^5.1.4",
"react": "18.2.0",
"react-test-renderer": "^18.2.0"
},
Expand Down
3 changes: 0 additions & 3 deletions repo-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,5 @@
"typescript": "4.1.3",
"ws": "^6.2.2",
"yargs": "^17.5.1"
},
"devDependencies": {
"mock-fs": "^5.1.4"
}
}

0 comments on commit b4fd178

Please sign in to comment.