feat: support custom library paths in `react-native.config.js` for codegen on iOS #34580

satya164 · 2022-09-02T12:18:44Z

Summary

Currently for codegen to work for a library on iOS, it needs to be located
inside node_modules. This patch adds support for libraries defined in
react-native.config.js.

This is useful when developing libraries as well as monorepos where the library
may exist outside of the node_modules.

Example:

// react-native.config.js
const path = require('path');

module.exports = {
  dependencies: {
    'react-native-library-name': {
      root: path.join(__dirname, '..'),
    },
  },
};

Changelog

[Internal] [Added] - Support custom library paths in react-native.config.js for codegen on iOS

Test Plan

Tested on a test application and ensured that codegen finds the library specified in react-native.config.js

Kapture.2022-09-02.at.14.16.49.mp4

I have also added a basic test case for this scenario.

Currently for codegen to work for a library on iOS, it needs to be located inside `node_modules`. This patch adds support for libraries defined in `react-native.config.js`. This is useful when developing libraries as well as monorepos where the library may exist outside of the `node_modules`. Example: ```js // react-native.config.js const path = require('path'); module.exports = { dependencies: { 'react-native-library-name': { root: path.join(__dirname, '..'), }, }, }; ```

github-actions · 2022-09-02T12:19:40Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 357bbbc

analysis-bot · 2022-09-02T12:45:13Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,635,165	-2,787
android	hermes	armeabi-v7a	7,047,162	-2,788
android	hermes	x86	7,937,127	-2,782
android	hermes	x86_64	7,909,156	-2,787
android	jsc	arm64-v8a	9,512,123	-1,626
android	jsc	armeabi-v7a	8,287,415	-1,632
android	jsc	x86	9,451,652	-1,638
android	jsc	x86_64	10,042,904	-1,630

Base commit: bf6a24b
Branch: main

analysis-bot · 2022-09-02T13:49:29Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: bf6a24b
Branch: main

facebook-github-bot · 2022-09-05T11:40:23Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi · 2022-09-05T11:41:58Z

@satya164, thanks for the PR. Some tests on windows. Can you have a look at them, please?

satya164 · 2022-09-06T12:02:58Z

@cipolleschi tests are passing now

facebook-github-bot · 2022-09-07T10:40:52Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-09-08T10:15:05Z

This pull request was successfully merged by @satya164 in a562216.

^{When will my fix make it into a release? | Upcoming Releases}

…degen on iOS (#34580) Summary: Currently for codegen to work for a library on iOS, it needs to be located inside `node_modules`. This patch adds support for libraries defined in `react-native.config.js`. This is useful when developing libraries as well as monorepos where the library may exist outside of the `node_modules`. Example: ```js // react-native.config.js const path = require('path'); module.exports = { dependencies: { 'react-native-library-name': { root: path.join(__dirname, '..'), }, }, }; ``` ## Changelog [Internal] [Added] - Support custom library paths in `react-native.config.js` for codegen on iOS Pull Request resolved: #34580 Test Plan: Tested on a test application and ensured that codegen finds the library specified in `react-native.config.js` https://user-images.githubusercontent.com/1174278/188141056-bce03730-2a13-4648-8889-9727aaf2c3c4.mp4 I have also added a basic test case for this scenario. Reviewed By: jacdebug, cortinico Differential Revision: D39257919 Pulled By: cipolleschi fbshipit-source-id: 131189f1941128a59b9b1e28af61a9038eb4536b

Summary: While working on 0.71 we noticed that we were hitting a "mock-fs not found" issue on CI, caused by the fact that the dependency was set in the wrong spot. This PR backports to main the fix: 05646f8 & ceaebc6 This is related to the black magics of repo-config, and the fact that devDeps from repo-config don't get propagated back to the root package.json when on stable branch. Because of that, this commit doesn't NOT have a yarn.lock entry (the dep is there in main). I'm confused as to how that dep ended in the devDeps of repo config, it seems something went wrong in migrating some commits from GH to monorepo and back? check out: * #34580 * f0ffd22 ## Changelog  [Internal] [Changed] - move mockfs to the right package.json Pull Request resolved: #35476 Test Plan: N/A, change is transparent Reviewed By: cortinico, cipolleschi, dmytrorykun Differential Revision: D41530265 Pulled By: jacdebug fbshipit-source-id: ec7a6426d9a2a766a98a3cccc339ca7ca090c3a0

…degen on iOS (facebook#34580) Summary: Currently for codegen to work for a library on iOS, it needs to be located inside `node_modules`. This patch adds support for libraries defined in `react-native.config.js`. This is useful when developing libraries as well as monorepos where the library may exist outside of the `node_modules`. Example: ```js // react-native.config.js const path = require('path'); module.exports = { dependencies: { 'react-native-library-name': { root: path.join(__dirname, '..'), }, }, }; ``` ## Changelog [Internal] [Added] - Support custom library paths in `react-native.config.js` for codegen on iOS Pull Request resolved: facebook#34580 Test Plan: Tested on a test application and ensured that codegen finds the library specified in `react-native.config.js` https://user-images.githubusercontent.com/1174278/188141056-bce03730-2a13-4648-8889-9727aaf2c3c4.mp4 I have also added a basic test case for this scenario. Reviewed By: jacdebug, cortinico Differential Revision: D39257919 Pulled By: cipolleschi fbshipit-source-id: 131189f1941128a59b9b1e28af61a9038eb4536b

) Summary: While working on 0.71 we noticed that we were hitting a "mock-fs not found" issue on CI, caused by the fact that the dependency was set in the wrong spot. This PR backports to main the fix: facebook@05646f8 & facebook@ceaebc6 This is related to the black magics of repo-config, and the fact that devDeps from repo-config don't get propagated back to the root package.json when on stable branch. Because of that, this commit doesn't NOT have a yarn.lock entry (the dep is there in main). I'm confused as to how that dep ended in the devDeps of repo config, it seems something went wrong in migrating some commits from GH to monorepo and back? check out: * facebook#34580 * facebook@f0ffd22 ## Changelog  [Internal] [Changed] - move mockfs to the right package.json Pull Request resolved: facebook#35476 Test Plan: N/A, change is transparent Reviewed By: cortinico, cipolleschi, dmytrorykun Differential Revision: D41530265 Pulled By: jacdebug fbshipit-source-id: ec7a6426d9a2a766a98a3cccc339ca7ca090c3a0

…act-native.config.js Summary: This feature was first introduced here facebook#34580 And then removed here facebook#41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [Internal] Differential Revision: D53267857

…act-native.config.js (facebook#42771) Summary: This feature was first introduced here facebook#34580 And then removed here facebook#41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [iOS][Fixed] - Bring back support for defining external libraries in react-native.config.js Reviewed By: cipolleschi Differential Revision: D53267857

…act-native.config.js (#42771) Summary: Pull Request resolved: #42771 This feature was first introduced here #34580 And then removed here #41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [iOS][Fixed] - Bring back support for defining external libraries in react-native.config.js Reviewed By: cipolleschi Differential Revision: D53267857 fbshipit-source-id: 7625dfe7b4a4651eb60eaec725f94f222a244e30

satya164 requested a review from hramos as a code owner September 2, 2022 12:18

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Callstack Partner: Callstack Partner labels Sep 2, 2022

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022

react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 2, 2022

satya164 force-pushed the @satya164/codegen-custom-path branch from 7b57cb9 to ee5c594 Compare September 6, 2022 09:38

test: add tests for finding libraries from react-native.config.js

357bbbc

satya164 force-pushed the @satya164/codegen-custom-path branch from ee5c594 to 357bbbc Compare September 6, 2022 10:33

facebook-github-bot closed this in a562216 Sep 8, 2022

react-native-bot added the Merged This PR has been merged. label Sep 8, 2022

satya164 deleted the @satya164/codegen-custom-path branch September 8, 2022 10:34

snyk-bot mentioned this pull request Oct 11, 2022

[Snyk] Upgrade react-native from 0.63.3 to 0.70.1 NOUIY/react-native-macos#806

Open

NOUIY mentioned this pull request Oct 25, 2022

[Snyk] Upgrade react-native from 0.63.3 to 0.70.2 NOUIY/react-native-macos#857

Open

NOUIY mentioned this pull request Nov 3, 2022

[Snyk] Upgrade react-native from 0.63.3 to 0.70.3 NOUIY/react-native-macos#887

Open

kelset mentioned this pull request Nov 25, 2022

fix(dependencies): move mockfs to the right package.json #35476

Closed

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.70) #41278

Closed

cipolleschi mentioned this pull request Jan 8, 2024

[0.70][RN][General] Migrate boost download url away from JFrog #42178

Merged

dmytrorykun mentioned this pull request Jan 31, 2024

iOS Codegen: bring back support for defining external libraries in react-native.config.js #42771

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support custom library paths in `react-native.config.js` for codegen on iOS #34580

feat: support custom library paths in `react-native.config.js` for codegen on iOS #34580

satya164 commented Sep 2, 2022

github-actions bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

facebook-github-bot commented Sep 5, 2022

cipolleschi commented Sep 5, 2022

satya164 commented Sep 6, 2022

facebook-github-bot commented Sep 7, 2022

react-native-bot commented Sep 8, 2022

feat: support custom library paths in react-native.config.js for codegen on iOS #34580

feat: support custom library paths in react-native.config.js for codegen on iOS #34580

Conversation

satya164 commented Sep 2, 2022

Summary

Changelog

Test Plan

github-actions bot commented Sep 2, 2022 • edited Loading

analysis-bot commented Sep 2, 2022 • edited Loading

analysis-bot commented Sep 2, 2022 • edited Loading

facebook-github-bot commented Sep 5, 2022

cipolleschi commented Sep 5, 2022

satya164 commented Sep 6, 2022

facebook-github-bot commented Sep 7, 2022

react-native-bot commented Sep 8, 2022

feat: support custom library paths in `react-native.config.js` for codegen on iOS #34580

feat: support custom library paths in `react-native.config.js` for codegen on iOS #34580

github-actions bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading