Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Local] Bump hermes-engine #41991

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[Local] Bump hermes-engine #41991

merged 1 commit into from
Dec 19, 2023

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Dec 19, 2023 •
edited
Loading

Summary:

Bumping Hermes-engine for 0.70 to have green CI

Changelog:

[Internal] - Bump hermes-engine

Test Plan:

CircleCI is green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.70-stable December 19, 2023 11:49
@github-actions GitHub Actions
Copy link

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against 346cb75

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-hermes-070-stable branch from 346cb75 to 303218e Compare December 19, 2023 13:49
@cipolleschi cipolleschi marked this pull request as ready for review December 19, 2023 13:49
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,600,599 -8,924,552
android hermes armeabi-v7a 7019334 n/a
android hermes x86 7902460 n/a
android hermes x86_64 7874164 n/a
android jsc arm64-v8a 9,482,181 -10,417,762
android jsc armeabi-v7a 8262935 n/a
android jsc x86 9422160 n/a
android jsc x86_64 1001331 n/a

Base commit: c45c13f
Branch: main

@lunaleaps lunaleaps merged commit 5b95254 into 0.70-stable Dec 19, 2023
14 of 18 checks passed
@cipolleschi cipolleschi mentioned this pull request Jan 8, 2024
Merged
@cortinico cortinico deleted the cipolleschi/fix-hermes-070-stable branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cipolleschi @analysis-bot @lunaleaps @facebook-github-bot