-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rrc_root
via prefab
#36166
Closed
Closed
Expose rrc_root
via prefab
#36166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Feb 15, 2023
cortinico
approved these changes
Feb 15, 2023
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 89ef5bd |
@cortinico merged this pull request in 3418f65. |
kelset
pushed a commit
that referenced
this pull request
Mar 6, 2023
Summary: The `rrc_root` was not exposed via prefab. I'm adding it to make possible for Reanimated to integrate on top of React Native via prefab. Based on #35643. ## Changelog [ANDROID] [CHANGED] - Expose `rrc_root` via prefab. Pull Request resolved: #36166 Reviewed By: cipolleschi Differential Revision: D43304302 Pulled By: cortinico fbshipit-source-id: 1c4a7013a33b48a8a7a445a78430630542420f4d
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: The `rrc_root` was not exposed via prefab. I'm adding it to make possible for Reanimated to integrate on top of React Native via prefab. Based on facebook#35643. ## Changelog [ANDROID] [CHANGED] - Expose `rrc_root` via prefab. Pull Request resolved: facebook#36166 Reviewed By: cipolleschi Differential Revision: D43304302 Pulled By: cortinico fbshipit-source-id: 1c4a7013a33b48a8a7a445a78430630542420f4d
Merged
This was referenced Jan 8, 2024
This was referenced Mar 1, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Summary: The `rrc_textinput` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `rrc_textinput` via prefab. Pull Request resolved: #43274 Reviewed By: cipolleschi Differential Revision: D54482657 Pulled By: cortinico fbshipit-source-id: ca7f4127f1808f841d88925238666e837de75bd0
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
Summary: The `rrc_text` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `rrc_text` via prefab. Pull Request resolved: #43275 Reviewed By: cipolleschi Differential Revision: D54536468 Pulled By: cortinico fbshipit-source-id: 8c4ef983467bfc46930f10bf7bd95761c2d11788
This was referenced Mar 8, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Summary: The `react_render_textlayoutmanager` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `react_render_textlayoutmanager` via prefab. Pull Request resolved: #43381 Reviewed By: javache Differential Revision: D54676207 Pulled By: cortinico fbshipit-source-id: 90e3b90ff842250bf1e3abcc0c54f057b68a82fd
huntie
pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: The `rrc_textinput` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `rrc_textinput` via prefab. Pull Request resolved: #43274 Reviewed By: cipolleschi Differential Revision: D54482657 Pulled By: cortinico fbshipit-source-id: ca7f4127f1808f841d88925238666e837de75bd0
huntie
pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: The `rrc_text` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `rrc_text` via prefab. Pull Request resolved: #43275 Reviewed By: cipolleschi Differential Revision: D54536468 Pulled By: cortinico fbshipit-source-id: 8c4ef983467bfc46930f10bf7bd95761c2d11788
huntie
pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: The `react_render_textlayoutmanager` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `react_render_textlayoutmanager` via prefab. Pull Request resolved: #43381 Reviewed By: javache Differential Revision: D54676207 Pulled By: cortinico fbshipit-source-id: 90e3b90ff842250bf1e3abcc0c54f057b68a82fd
facebook-github-bot
pushed a commit
that referenced
this pull request
May 28, 2024
Summary: The `mapbufferjni` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `mapbufferjni` via prefab. Pull Request resolved: #44684 Reviewed By: fabriziocucci Differential Revision: D57856389 Pulled By: javache fbshipit-source-id: 9926b02724950f4025c7f867257e8229d44c43a3
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: The `mapbufferjni` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on facebook#36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `mapbufferjni` via prefab. Pull Request resolved: facebook#44684 Reviewed By: fabriziocucci Differential Revision: D57856389 Pulled By: javache fbshipit-source-id: 9926b02724950f4025c7f867257e8229d44c43a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
rrc_root
was not exposed via prefab. I'm adding it to make possible for Reanimated to integrate on top of React Native via prefab. Based on #35643.Changelog
[ANDROID] [CHANGED] - Expose
rrc_root
via prefab.Test Plan