-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rrc_textinput
via prefab
#43274
Conversation
Base commit: 1d8dea5 |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@tomekzaw do we need this for RC4? If yes please add a pick request. |
@cortinico Yes, definitely, I've asked to pick for both PRs here: reactwg/react-native-releases#104 (comment)
A single prefab would be a game-changer! Thanks for letting us know, we will make necessary changes on the libraries' side. Happy to test out the changes via nightly to see if it's working correctly or even contribute that change according to your instructions. |
@cortinico merged this pull request in adc9e5b. |
Summary: The `rrc_textinput` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `rrc_textinput` via prefab. Pull Request resolved: #43274 Reviewed By: cipolleschi Differential Revision: D54482657 Pulled By: cortinico fbshipit-source-id: ca7f4127f1808f841d88925238666e837de75bd0
Summary:
The
rrc_textinput
was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.Changelog:
[ANDROID] [CHANGED] - Expose
rrc_textinput
via prefab.Test Plan: