Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rrc_textinput via prefab #43274

Closed
wants to merge 2 commits into from
Closed

Expose rrc_textinput via prefab #43274

wants to merge 2 commits into from

Conversation

tomekzaw
Copy link
Contributor

@tomekzaw tomekzaw commented Mar 1, 2024

Summary:

The rrc_textinput was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.

Changelog:

[ANDROID] [CHANGED] - Expose rrc_textinput via prefab.

Test Plan:

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 1, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,009,266 +5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,367,671 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1d8dea5
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico cortinico self-assigned this Mar 4, 2024
@cortinico
Copy link
Contributor

@tomekzaw do we need this for RC4? If yes please add a pick request.
Also please note that we're still panning in exposing a single prefab target out of React Native in the future (most likely in 0.75/0.76) so this will be a breaking change for react-native-live-markdown.

@tomekzaw
Copy link
Contributor Author

tomekzaw commented Mar 4, 2024

do we need this for RC4? If yes please add a pick request.

@cortinico Yes, definitely, I've asked to pick for both PRs here: reactwg/react-native-releases#104 (comment)

Also please note that we're still panning in exposing a single prefab target out of React Native in the future (most likely in 0.75/0.76) so this will be a breaking change for react-native-live-markdown.

A single prefab would be a game-changer! Thanks for letting us know, we will make necessary changes on the libraries' side. Happy to test out the changes via nightly to see if it's working correctly or even contribute that change according to your instructions.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 4, 2024
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in adc9e5b.

huntie pushed a commit that referenced this pull request Mar 11, 2024
Summary:
The `rrc_textinput` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[ANDROID] [CHANGED] - Expose `rrc_textinput` via prefab.

Pull Request resolved: #43274

Reviewed By: cipolleschi

Differential Revision: D54482657

Pulled By: cortinico

fbshipit-source-id: ca7f4127f1808f841d88925238666e837de75bd0
This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants