Ability to always log certain performance entry types #36820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44712550 |
Base commit: 01100a2 |
|
This pull request was exported from Phabricator. Differential Revision: D44712550 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 6, 2023
Summary: Pull Request resolved: facebook#36820 ## Changelog: [Internal] - A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless). This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries. Also expands unit tests for the JS side of the `Performance` API correspondingly. Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either: * explicitly requested via `Performance.getEntries*` * actually observed via `PerformanceObserver` Differential Revision: D44712550 fbshipit-source-id: db15ae5e4ba0aa4dc9db12102808c59ca34096eb
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 6, 2023
Summary: Pull Request resolved: facebook#36820 ## Changelog: [Internal] - A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless). This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries. Also expands unit tests for the JS side of the `Performance` API correspondingly. Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either: * explicitly requested via `Performance.getEntries*` * actually observed via `PerformanceObserver` Differential Revision: D44712550 fbshipit-source-id: e4cff4bd0f52c9f2c78be9aaa05de09367a5d5dd
|
This pull request was exported from Phabricator. Differential Revision: D44712550 |
Summary: Pull Request resolved: facebook#36820 ## Changelog: [Internal] - A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless). This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries. Also expands unit tests for the JS side of the `Performance` API correspondingly. Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either: * explicitly requested via `Performance.getEntries*` * actually observed via `PerformanceObserver` Reviewed By: rubennorte Differential Revision: D44712550 fbshipit-source-id: 9557d29db3341ca662759385ccfbc34b6479763d
|
This pull request was exported from Phabricator. Differential Revision: D44712550 |
|
This pull request has been merged in 3506c8d. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36820 ## Changelog: [Internal] - A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless). This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries. Also expands unit tests for the JS side of the `Performance` API correspondingly. Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either: * explicitly requested via `Performance.getEntries*` * actually observed via `PerformanceObserver` Reviewed By: rubennorte Differential Revision: D44712550 fbshipit-source-id: 7fc891b09bd00fa9b510d1dc059cf908d5caea07
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36820 ## Changelog: [Internal] - A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless). This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries. Also expands unit tests for the JS side of the `Performance` API correspondingly. Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either: * explicitly requested via `Performance.getEntries*` * actually observed via `PerformanceObserver` Reviewed By: rubennorte Differential Revision: D44712550 fbshipit-source-id: 7fc891b09bd00fa9b510d1dc059cf908d5caea07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless).
This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries.
Also expands unit tests for the JS side of the
PerformanceAPI correspondingly.Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either:
Performance.getEntries*PerformanceObserverDifferential Revision: D44712550