Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to always log certain performance entry types #36820

Closed
wants to merge 1 commit into from
Closed

Ability to always log certain performance entry types #36820

wants to merge 1 commit into from

Commits on Apr 6, 2023

  1. Ability to always log certain performance entry types (facebook#36820) 

    Summary:
Pull Request resolved: facebook#36820

## Changelog:
[Internal] -

A follow-up to the D44584166 (which was abandoned, but this change makes sense nevertheless).

This allows to selectively enable logging of certain event types regardless of whether they are observed or not. For now it's marks and measures, but potentially it may be also e.g. navigation/resource entries.

Also expands unit tests for the JS side of the `Performance` API correspondingly.

Note that "always logged" and "observed" have different semantics. An "always logged" entry won't be sent back from native to JS, unless either:
* explicitly requested via `Performance.getEntries*`
* actually observed via `PerformanceObserver`

Reviewed By: rubennorte

Differential Revision: D44712550

fbshipit-source-id: 9557d29db3341ca662759385ccfbc34b6479763d
    @rshest @facebook-github-bot
    rshest authored and facebook-github-bot committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7280d75 View commit details
    Browse the repository at this point in the history