New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings for `alignContent: "space-evenly"` #41020

Closed

NickGerleman wants to merge 3 commits into facebook:main from NickGerleman:export-D50347978

Contributor

NickGerleman commented Oct 16, 2023

Summary:
This adds Fabric and Paper bindings to support alignContent: "space-evenly" as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for alignContent: "space-evenly"

Differential Revision: D50347978

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

analysis-bot commented Oct 17, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,623,869	+66
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,997,421	+63
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 2bf1a8f
Branch: main

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

72add82

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Differential Revision: D50347978

fbshipit-source-id: aea8493f2b771651ff3142d45d01b3939aa0b01b

NickGerleman force-pushed the export-D50347978 branch from 68ea9e7 to 72add82 Compare

October 17, 2023 01:16

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

a493bed

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Differential Revision: D50347978

fbshipit-source-id: 2f4d33ffc7411a04bc3f9ed4b345b01489810bc0

NickGerleman force-pushed the export-D50347978 branch from 72add82 to a493bed Compare

October 17, 2023 02:08

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

53ebdea

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: 00a11f003ecc6ad424215bd4a60b638a14c4afca

NickGerleman force-pushed the export-D50347978 branch from a493bed to 53ebdea Compare

October 17, 2023 17:54

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

45d20bb

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: a7a1395c19f0b54cda1755dfc0c839cd1ef1f65d

NickGerleman force-pushed the export-D50347978 branch from 53ebdea to 45d20bb Compare

October 17, 2023 18:12

NickGerleman added a commit to facebook/react-native-website that referenced this pull request


          Add alignContent: 'space-evenly'

5fcc1fc

Coming with 0.74

facebook/react-native#41020

NickGerleman mentioned this pull request

Add alignContent: 'space-evenly' facebook/react-native-website#3888

Merged

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

8ff5bb3

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: 3ba6839706f84d023d0d2e30a5d58c6d837d3856

NickGerleman force-pushed the export-D50347978 branch from 45d20bb to 8ff5bb3 Compare

October 17, 2023 18:27

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

42984e2

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: 70debc0bc2ba7c14e4cd451ab2e42c93d6eec520

NickGerleman force-pushed the export-D50347978 branch from 8ff5bb3 to 42984e2 Compare

October 17, 2023 18:50

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

4e0dfe8

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: b773ca19e1db82b8b381bbb984bb844042dcfc3f

NickGerleman force-pushed the export-D50347978 branch from 42984e2 to 4e0dfe8 Compare

October 17, 2023 18:55

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

eeec8e0

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: b4140267d88d5785b9f4eaf7a85d14c33ddf42fd

NickGerleman force-pushed the export-D50347978 branch from 4e0dfe8 to eeec8e0 Compare

October 17, 2023 19:36

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

438def4

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: 3e1096e880d0834110251009c4caec1dab5355f1

NickGerleman force-pushed the export-D50347978 branch from eeec8e0 to 438def4 Compare

October 17, 2023 19:47

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

322b6df

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: acbc0325490be4b0b376586eeaab42a6bdbcd8cc

NickGerleman force-pushed the export-D50347978 branch from 438def4 to 322b6df Compare

October 17, 2023 20:10

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

c53a580

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: 5e5914f71a7161cb55e8c5c30044236f800b1cf8

NickGerleman force-pushed the export-D50347978 branch from 322b6df to c53a580 Compare

October 17, 2023 21:01

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

6abbc9b

Summary:

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

NickGerleman force-pushed the export-D50347978 branch from c53a580 to 6abbc9b Compare

October 17, 2023 22:35

Contributor

facebook-github-bot commented Oct 17, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

nicoburns and others added 3 commits

October 17, 2023 20:54


          Support "align-content: space-evenly" (facebook#41019)

4c76051

Summary:

### Changes made
- Regenerated tests (as some aspect ratio tests seem to be out of date compared to the fixtures)
- Added SpaceEvenly variant to the "Align" enums (via enums.py)
- Implemented `align-content: space-evenly` alignment in CalculateLayout.cpp
- Added generated tests `align-content: space-evenly`
- Updated NumericBitfield test to account for the fact that the Align enum now requires more bits (this bit could do with being reviewed as I am not 100% certain that it's valid to just update the test like this).

### Changes not made
- Any attempt to improve the spec-compliance of content alignment in general (e.g. I think facebook/yoga#1013 probably still needs to happen)

X-link: facebook/yoga#1422

Reviewed By: yungsters

Differential Revision: D50305438

Pulled By: NickGerleman


          Reuse Yoga enum ToString functions (facebook#41021)

b37ec4e

Summary:

Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric.

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D50347728


          Bindings for alignContent: "space-evenly" (facebook#41020)

82cc3a6

Summary:

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

NickGerleman force-pushed the export-D50347978 branch from 6abbc9b to 82cc3a6 Compare

October 18, 2023 03:55

Contributor

facebook-github-bot commented Oct 18, 2023

This pull request was exported from Phabricator. Differential Revision: D50347978

facebook-github-bot closed this in

c9d0a00

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Oct 18, 2023

This pull request has been merged in c9d0a00.

Othinn pushed a commit to Othinn/react-native that referenced this pull request


          Bindings for alignContent: "space-evenly" (facebook#41020)

4a7aba2

Summary:
Pull Request resolved: facebook#41020

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978

fbshipit-source-id: 44df3b8ddc7171cddf56957c11ac7d975f706f9d

NickGerleman added a commit to facebook/react-native-website that referenced this pull request


          Add alignContent: 'space-evenly' (#3888)

cc46589

* Add `alignContent: 'space-evenly'`

Coming with 0.74

facebook/react-native#41020

* Update layout-props.md

sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request


          Squashed commit of the following:

1f11d3d

commit 6a28b05
Author: Kartik Shankhavaram <shankhavaramk@gmail.com>
Date:   Sat Dec 9 22:50:21 2023 +0800

    Change 'use' to 'lose' to signify that functions are still accessible (facebook#3949)

commit 822b280
Author: Alex Hunt <hello@alexhunt.io>
Date:   Fri Dec 8 13:00:46 2023 +0000

    [docs] Fix name for 0.73 versioned docs (facebook#3948)

commit 4818763
Author: Nick Gerleman <ngerlem@meta.com>
Date:   Thu Dec 7 10:56:32 2023 -0800

    Lint and typecheck examples against RN 0.73 (facebook#3946)

    * Lint and typecheck examples against RN 0.73

    Updates the harness for linting snack examples to the newest version of RN.

    * Update Netlify Node version

commit cc46589
Author: Nick Gerleman <ngerlem@meta.com>
Date:   Thu Dec 7 10:56:04 2023 -0800

    Add `alignContent: 'space-evenly'` (facebook#3888)

    * Add `alignContent: 'space-evenly'`

    Coming with 0.74

    facebook/react-native#41020

    * Update layout-props.md

commit 9f7093c
Author: Christoph Purrer <christophpurrer@gmail.com>
Date:   Thu Dec 7 14:06:00 2023 +0100

    Simplify C++ TM struct generation (facebook#3947)

    Update documentation to match:
    facebook/react-native#41645

commit 59278e7
Author: Nick Gerleman <ngerlem@meta.com>
Date:   Thu Dec 7 01:28:12 2023 -0800

    Add `--frozen-lockfile` to `yarn install` (facebook#3945)

    To catch cases where dependency changes require a lockfile change that wasn't comited alongside.

commit 06ba8ea
Author: Nick Gerleman <ngerlem@meta.com>
Date:   Thu Dec 7 00:59:10 2023 -0800

    Revert "fixed peer dependency issues (facebook#3942)" (facebook#3944)

    This reverts commit 1bcb60f.

commit 1bcb60f
Author: Shantanu Gupta <99300527+Shantanugupta43@users.noreply.github.com>
Date:   Thu Dec 7 08:52:32 2023 +0000

    fixed peer dependency issues (facebook#3942)

    * fixed peer dependency issues

    * removed lingering file

commit 79ff42a
Author: Zeya Peng <zeyap@users.noreply.github.com>
Date:   Wed Dec 6 14:20:06 2023 -0500

    Update native-components-android.md (facebook#3941)

commit f0c4b80
Author: Aike van den Brink <17004429+aikewoody@users.noreply.github.com>
Date:   Wed Dec 6 19:46:03 2023 +0100

    Update new-architecture-app-intro.md (facebook#3938)

    Fixed small spelling mistake

commit f89ab82
Author: Alex Hunt <hello@alexhunt.io>
Date:   Wed Dec 6 17:56:40 2023 +0000

    [docs] Cut version 0.73.0 (facebook#3940)

commit 83e816b
Author: Alex Hunt <hello@alexhunt.io>
Date:   Wed Dec 6 17:15:14 2023 +0000

    [blog] Add 0.73 announcement post (facebook#3931)

commit d8c78ad
Author: Thibault Malbranche <thibault.malbranche@epitech.eu>
Date:   Wed Dec 6 17:33:48 2023 +0100

    fix(Image): update link to correct file (facebook#3939)

commit 821172e
Author: Sarvar Rose <47109217+sarvarrose@users.noreply.github.com>
Date:   Mon Dec 4 16:20:11 2023 +0530

    correct type of Pressable `style` prop (facebook#3936)

commit b1379a7
Author: adriancuadrado <adriancuadradochavarria97@gmail.com>
Date:   Mon Dec 4 00:57:19 2023 +0100

    Update scrollview.md (facebook#3869)

    `pagingEnabled` **is** supported on Android. I tested it and it just seems to work.

commit 11258b1
Author: Alan <49978973+3Alan@users.noreply.github.com>
Date:   Mon Dec 4 07:55:12 2023 +0800

    fix: remove useless points (facebook#3934)

commit 8400279
Author: Christoph Purrer <christophpurrer@gmail.com>
Date:   Sun Dec 3 09:57:25 2023 +0100

    Revert "Simplify C++ TM struct generation (facebook#3930)" (facebook#3935)

    This reverts commit 7396470.

commit 7396470
Author: Christoph Purrer <christophpurrer@gmail.com>
Date:   Mon Nov 27 13:00:23 2023 +0100

    Simplify C++ TM struct generation (facebook#3930)

    Update documentation to match:
    facebook/react-native#41645

commit 5616873
Author: Bailey Lissington <54869395+llamington@users.noreply.github.com>
Date:   Mon Nov 27 22:33:50 2023 +1300

    Fixed grammatical error (facebook#3929)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner