Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings for alignContent: "space-evenly" #41020

Closed
wants to merge 3 commits into from
Closed

Bindings for alignContent: "space-evenly" #41020

wants to merge 3 commits into from

Commits on Oct 18, 2023

  1. Support "align-content: space-evenly" (facebook#41019) 

    Summary:

### Changes made
- Regenerated tests (as some aspect ratio tests seem to be out of date compared to the fixtures)
- Added SpaceEvenly variant to the "Align" enums (via enums.py)
- Implemented `align-content: space-evenly` alignment in CalculateLayout.cpp
- Added generated tests `align-content: space-evenly`
- Updated NumericBitfield test to account for the fact that the Align enum now requires more bits (this bit could do with being reviewed as I am not 100% certain that it's valid to just update the test like this).

### Changes not made
- Any attempt to improve the spec-compliance of content alignment in general (e.g. I think facebook/yoga#1013 probably still needs to happen)

X-link: facebook/yoga#1422

Reviewed By: yungsters

Differential Revision: D50305438

Pulled By: NickGerleman
    @nicoburns @facebook-github-bot
    nicoburns authored and facebook-github-bot committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    4c76051 View commit details
    Browse the repository at this point in the history

  2. Reuse Yoga enum ToString functions (facebook#41021) 

    Summary:

Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric.

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D50347728
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b37ec4e View commit details
    Browse the repository at this point in the history

  3. Bindings for alignContent: "space-evenly" (facebook#41020) 

    Summary:

This adds Fabric and Paper bindings to support `alignContent: "space-evenly"` as implemented in facebook/yoga#1422

Changelog:
[General][Added] - Bindings for `alignContent: "space-evenly"`

Reviewed By: yungsters

Differential Revision: D50347978
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    82cc3a6 View commit details
    Browse the repository at this point in the history