Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete LazyReactPackage.getReactModuleInfoProviderViaReflection #41096

Closed
wants to merge 2 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Oct 19, 2023

Summary:
LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

@analysis-bot
Copy link

analysis-bot commented Oct 19, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,653,252 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,035,015 +4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: daedbe6
Branch: main

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 20, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 21, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 21, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 21, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@mdvacca mdvacca force-pushed the export-D50338302 branch 2 times, most recently from 370ce0b to e2fa5e6 Compare October 23, 2023 16:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 23, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 24, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 24, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 25, 2023
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
…book#41096)

Summary:

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338302

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 118e651.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Oct 30, 2023
…book#41096)

Summary:
Pull Request resolved: facebook#41096

LazyReactPackage.getReactModuleInfoProviderViaReflection was deprecated in 0.72, I'm just deleting it.
There are no usages internally or externally

changelog: [Android][Breaking] Delete deprecated method LazyReactPackage.getReactModuleInfoProviderViaReflection

Reviewed By: arushikesarwani94

Differential Revision: D50338302

fbshipit-source-id: 02fe91d5da8d6f01b8d3852aced90034a1a5c8e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants