Fix CI by adding explicit visibility modifier to BridgelessCatalystInstance #43296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance Summary: Fix CI by adding explicit visibility modifier to the newly added `BridgelessCatalystInstance` class. In Kotlin, in explicit API mode, which is usually the default mode for Kotlin, we must explicitly specify one of the modifiers for every declaration to make it clear and explicit. Changelog: [Internal] internal Differential Revision: D54442485
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54442485 |
Base commit: 2053364 |
|
This pull request has been merged in 7d47781. |
huntie
pushed a commit
that referenced
this pull request
Mar 18, 2024
…stance (#43296) Summary: Pull Request resolved: #43296 Fix CI by adding explicit visibility modifier to the newly added `BridgelessCatalystInstance` class. In Kotlin, in explicit API mode, which is usually the default mode for Kotlin, we must explicitly specify one of the modifiers for every declaration to make it clear and explicit. Changelog: [Internal] internal Reviewed By: makovkastar Differential Revision: D54442485 fbshipit-source-id: 4409ff810a09cc4fadcd2ccf21f7fbac3015f413
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix CI by adding explicit visibility modifier to the newly added
BridgelessCatalystInstanceclass. In Kotlin, in explicit API mode, which is usually the default mode for Kotlin, we must explicitly specify one of the modifiers for every declaration to make it clear and explicit.Changelog:
[Internal] internal
Differential Revision: D54442485