Fix E2E template install in CI jobs #43323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `test_ios_template` job Differential Revision: D54536848
|
This pull request was exported from Phabricator. Differential Revision: D54536848 |
facebook-github-bot
added
CLA Signed
Base commit: f043c83 |
|
This pull request has been merged in 42cab14. |
huntie
added a commit
that referenced
this pull request
Mar 18, 2024
Summary: Pull Request resolved: #43323 This fixes a seemingly pre-existent misconfiguration within our `test_ios_template` E2E test setup in CircleCI. **Background** We call `npx react-native-community/cli init` with the `--skip-install` flag, as part of the bootstrapping logic in `scripts/e2e/init-template-e2e.js`. This is necessary because we later want to explicitly call `npm install` with a custom `--registry` for our locally mirrored packages (via Verdaccio). For some reason, we were observing unexpected differences when this was run under CircleCI: 1. Runs `yarn init` 2. Runs a `yarn add` (unknown pkg) {F1464781818} https://app.circleci.com/pipelines/github/facebook/react-native/42725/workflows/f648468b-e916-4501-887d-ad293aa6fccf/jobs/1398950 This is causing a Yarn-based install ahead of where we want — ignoring the `--skip-install` flag. *I'm still unsure on the exact LOC cause in CLI* (but most likely, it's around the Yarn v3 move). **Impact of this fix** - The above meant that, when we were bootstrapping `test_ios_template` previously, packages weren't being read from Verdaccio, but **instead from npm** — using the `"0.74.0"` versions from the *previous branch cut* ❌. - After D54006327, this behaviour became breaking 💀 — since for the 0.74 -> 0.75 cut, we no longer physically published `"0.75.0-main"` (new format) packages to npm. **This change** I'm passing `--pm npm` to `npx react-native-community/cli init` to skip around any Yarn behaviour. This appears to have removed the erroneous `yarn` invocations ✅. Changelog: [Internal] bypass-github-export-checks Reviewed By: cortinico, cipolleschi Differential Revision: D54536848 fbshipit-source-id: 473b11924955f5787c82a6c81d4527d77b810aa5
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a seemingly pre-existent misconfiguration within our
test_ios_templateE2E test setup in CircleCI.Background
We call
npx @react-native-community/cli initwith the--skip-installflag, as part of the bootstrapping logic inscripts/e2e/init-template-e2e.js. This is necessary because we later want to explicitly callnpm installwith a custom--registryfor our locally mirrored packages (via Verdaccio).For some reason, we were observing unexpected differences when this was run under CircleCI:
yarn inityarn add(unknown pkg)https://app.circleci.com/pipelines/github/facebook/react-native/42725/workflows/f648468b-e916-4501-887d-ad293aa6fccf/jobs/1398950
This is causing a Yarn-based install ahead of where we want — ignoring the
--skip-installflag.I'm still unsure on the exact LOC cause in CLI (but most likely, it's around the Yarn v3 move).
Impact of this fix
test_ios_templatepreviously, packages weren't being read from Verdaccio, but instead from npm — using the"0.74.0"versions from the previous branch cut ❌."0.75.0-main"(new format) packages to npm.This change
I'm passing
--pm npmtonpx @react-native-community/cli initto skip around any Yarn behaviour. This appears to have removed the erroneousyarninvocations ✅.Changelog: [Internal]
Differential Revision: D54536848