Support onActivityResult in Bridgeless #43351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54574139 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 6, 2024
Summary: Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Differential Revision: D54574139
arushikesarwani94
force-pushed
the
export-D54574139
branch
from
a69eaca to
72e2bda
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54574139 |
Base commit: 3ed0ff3 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 6, 2024
Summary: Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54574139
arushikesarwani94
force-pushed
the
export-D54574139
branch
from
72e2bda to
dc8c80c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54574139 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 6, 2024
Summary: Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54574139
arushikesarwani94
force-pushed
the
export-D54574139
branch
from
dc8c80c to
a67dedc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54574139 |
Summary: Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54574139
arushikesarwani94
force-pushed
the
export-D54574139
branch
from
a67dedc to
889eedf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54574139 |
alanjhughes
reviewed
Mar 6, 2024
Comment on lines
+632
to
+636
| ReactSoftExceptionLogger.logSoftException( | ||
| TAG, | ||
| new ReactNoCrashSoftException( | ||
| "Tried to access onActivityResult while context is not ready")); | ||
| } |
There was a problem hiding this comment.
Should this be called unconditionally?
There was a problem hiding this comment.
Doesn't this only makes sense in case the context is null ?
|
This pull request has been merged in c771011. |
3 tasks
huntie
pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: Pull Request resolved: #43351 Implement `onActivityResult` on Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54574139 fbshipit-source-id: f2369077199186ac6ef0187b5dfe7ed95f3b87fc
This was referenced Apr 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement
onActivityResulton BridgelessChangelog:
[Internal] internal
Differential Revision: D54574139