[Fabric] iOS: Change image source url encode ascii to utf8 #43502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
I can confirm this solves #43462 👍 |
cortinico
approved these changes
Mar 15, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@zhongwuzw this is amazing! Thanks for looking into it and fixing it so quickly 🙏 |
|
@cortinico merged this pull request in fa8fdc7. |
huntie
pushed a commit
that referenced
this pull request
Mar 18, 2024
Summary: We should use utf8 to cover more characters. ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Change image source url encode ascii to utf8 Pull Request resolved: #43502 Test Plan: Fixes #43462 Reviewed By: rshest Differential Revision: D54944653 Pulled By: cortinico fbshipit-source-id: 0bbd3d46c8e5c04ceffe7e0ebae46dc2ce9507df
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We should use utf8 to cover more characters.
Changelog:
[IOS] [FIXED] - [Fabric] iOS: Change image source url encode ascii to utf8
Test Plan:
Fixes #43462