Keep ES6Proxy enabled in bridgeless mode #43538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55045780 |
This was referenced Mar 19, 2024
Base commit: ac714b1 |
fkgozali
force-pushed
the
export-D55045780
branch
from
a423f69 to
bb2f7af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55045780 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Mar 25, 2024
Summary: The Hermes RuntimeConfig for bridgeless accidentally force-disabled ES6Proxy, resulting in facebook#43523 Let's remove the incorrect override. To test using RNTester, add the following change: ``` diff --git a/packages/rn-tester/js/RNTesterAppShared.js b/packages/rn-tester/js/RNTesterAppShared.js index 87cb6b69dfe..f2512d09c5a 100644 --- a/packages/rn-tester/js/RNTesterAppShared.js +++ b/packages/rn-tester/js/RNTesterAppShared.js @@ -50,6 +50,8 @@ const RNTesterApp = ({ ); const colorScheme = useColorScheme(); + new Proxy({}, {}); + const { activeModuleKey, activeModuleTitle, ``` Before this change, RNTester will get an error at start-up. After, the app loads correctly. Changelog: [General][Fixed] Correctly keep ES6Proxy for bridgeless mode Reviewed By: cortinico Differential Revision: D55045780
Summary: The Hermes RuntimeConfig for bridgeless accidentally force-disabled ES6Proxy, resulting in facebook#43523 Let's remove the incorrect override. To test using RNTester, add the following change: ``` diff --git a/packages/rn-tester/js/RNTesterAppShared.js b/packages/rn-tester/js/RNTesterAppShared.js index 87cb6b69dfe..f2512d09c5a 100644 --- a/packages/rn-tester/js/RNTesterAppShared.js +++ b/packages/rn-tester/js/RNTesterAppShared.js @@ -50,6 +50,8 @@ const RNTesterApp = ({ ); const colorScheme = useColorScheme(); + new Proxy({}, {}); + const { activeModuleKey, activeModuleTitle, ``` Before this change, RNTester will get an error at start-up. After, the app loads correctly. Changelog: [General][Fixed] Correctly keep ES6Proxy for bridgeless mode Reviewed By: cortinico Differential Revision: D55045780
fkgozali
force-pushed
the
export-D55045780
branch
from
bb2f7af to
e6d2446
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55045780 |
|
This pull request has been merged in c356309. |
huntie
pushed a commit
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: #43538 The Hermes RuntimeConfig for bridgeless accidentally force-disabled ES6Proxy, resulting in #43523 Let's remove the incorrect override. To test using RNTester, add the following change: ``` diff --git a/packages/rn-tester/js/RNTesterAppShared.js b/packages/rn-tester/js/RNTesterAppShared.js index 87cb6b69dfe..f2512d09c5a 100644 --- a/packages/rn-tester/js/RNTesterAppShared.js +++ b/packages/rn-tester/js/RNTesterAppShared.js @@ -50,6 +50,8 @@ const RNTesterApp = ({ ); const colorScheme = useColorScheme(); + new Proxy({}, {}); + const { activeModuleKey, activeModuleTitle, ``` Before this change, RNTester will get an error at start-up. After, the app loads correctly. Changelog: [General][Fixed] Correctly keep ES6Proxy for bridgeless mode Reviewed By: cortinico Differential Revision: D55045780 fbshipit-source-id: 666b99712d35622f87d42f22a4611851df67d905
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Hermes RuntimeConfig for bridgeless accidentally force-disabled ES6Proxy, resulting in #43523
To fix it, let's remove the incorrect override.
To test using RNTester, add the following change:
Before this change, RNTester will get an error at start-up. After, the app loads correctly.
Changelog: [General][Fixed] Correctly keep ES6Proxy for bridgeless mode
Differential Revision: D55045780