Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to fix ccache_enabled option, fixes #43633 #43634

Closed
wants to merge 1 commit into from

Conversation

CatStudioApp
Copy link
Contributor

@CatStudioApp CatStudioApp commented Mar 24, 2024

Summary:

I found in 0.74.0-rc.x, ccache_enabled is introduced. However, it is not being delivered via npm.

fixes #43633

Changelog: [iOS] [Fixed] - Adding ccache_clang wrapper scripts to package.json for distribution

Test Plan

I ran the build with ccache_enabled to reproduce on 0.74-rc.4:

diff --git a/ios/Podfile b/ios/Podfile
index 9416525..faec5a7 100644
--- a/ios/Podfile
+++ b/ios/Podfile
@@ -34,7 +34,7 @@ target 'Newish' do
       installer,
       config[:reactNativePath],
       :mac_catalyst_enabled => false,
-      # :ccache_enabled => true
+      :ccache_enabled => true
     )
   end
 end

This fails at build in Xcode:
CleanShot 2024-03-25 at 21 56 08@2x

After applying the fix (npm publish --dry-run 2>&1 | grep "scripts/xcode") and confirming by replicating this in the above project, the builds was successful:

CleanShot 2024-03-25 at 21 58 25@2x

@facebook-github-bot
Copy link
Contributor

Hi @CatStudioApp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@CatStudioApp CatStudioApp changed the title Update package.json to fix ccache_enabled option Update package.json to fix ccache_enabled option, fixes #43633 Mar 24, 2024
@CatStudioApp
Copy link
Contributor Author

CLA signed... not sure why it is not updated

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,171,335 -9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,540,479 +4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4c8e253
Branch: main

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 24, 2024
@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@blakef
Copy link
Contributor

blakef commented Mar 25, 2024

Thank you for this fix.

Added test plan notes I used to validate the fix (locally) to the summary.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 25, 2024
@facebook-github-bot
Copy link
Contributor

@blakef merged this pull request in 1c8751a.

huntie pushed a commit that referenced this pull request Apr 2, 2024
)

Summary:
I found in 0.74.0-rc.x, `ccache_enabled` is introduced. However, it is not being delivered via npm.

fixes #43633

Changelog: [iOS] [Fixed] - Adding ccache_clang wrapper scripts to package.json for distribution

Pull Request resolved: #43634

Reviewed By: cortinico

Differential Revision: D55308743

Pulled By: blakef

fbshipit-source-id: e89a4bb3a1fbf8562d880b4c9d25dc9083717ba6
This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
4 participants