-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json to fix ccache_enabled
option, fixes #43633
#43634
Conversation
Hi @CatStudioApp! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
ccache_enabled
optionccache_enabled
option, fixes #43633
CLA signed... not sure why it is not updated |
Base commit: 4c8e253 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thank you for this fix.
|
) Summary: I found in 0.74.0-rc.x, `ccache_enabled` is introduced. However, it is not being delivered via npm. fixes #43633 Changelog: [iOS] [Fixed] - Adding ccache_clang wrapper scripts to package.json for distribution Pull Request resolved: #43634 Reviewed By: cortinico Differential Revision: D55308743 Pulled By: blakef fbshipit-source-id: e89a4bb3a1fbf8562d880b4c9d25dc9083717ba6
Summary:
I found in 0.74.0-rc.x,
ccache_enabled
is introduced. However, it is not being delivered via npm.fixes #43633
Changelog: [iOS] [Fixed] - Adding ccache_clang wrapper scripts to package.json for distribution
Test Plan
I ran the build with
ccache_enabled
to reproduce on 0.74-rc.4:This fails at build in Xcode:
After applying the fix (
npm publish --dry-run 2>&1 | grep "scripts/xcode"
) and confirming by replicating this in the above project, the builds was successful: