Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more stubbed methods in BridgelessCatalystInstance #44091

Closed
wants to merge 1 commit into from

Conversation

javache
Copy link
Member

@javache javache commented Apr 15, 2024

Summary:
These can be stubbed easily using existing ReactHostImpl/ReactInstance API's

Changelog: [Internal]

Differential Revision: D56139806

Summary:
These can be stubbed easily using existing ReactHostImpl/ReactInstance API's

Changelog: [Internal]

Differential Revision: D56139806
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56139806

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,385,254 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,760,267 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5d538ec
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5e7f74d.

Copy link

This pull request was successfully merged by @javache in 5e7f74d.

When will my fix make it into a release? | How to file a pick request?

cipolleschi pushed a commit that referenced this pull request May 2, 2024
Summary:
Pull Request resolved: #44091

These can be stubbed easily using existing ReactHostImpl/ReactInstance API's

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D56139806

fbshipit-source-id: cefabe3aa0fb6556f8e296243ff233df07ddffee
@javache javache deleted the export-D56139806 branch May 14, 2024 10:49
This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants