-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align debugger Chrome launch flags with Meta-internal version #44180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [General][Changed] Update Chrome launch flags for `--experimental-debugger` launch flow Internally at Meta, we've been testing the experimental debugger launch flow with a different set of Chrome flags than are currently shipped in open source. This diff fixes those differences: * Removes `--disable-backgrounding-occluded-windows` * Adds `--guest` Reviewed By: EdmondChuiHW Differential Revision: D56418271
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 22, 2024
This pull request was exported from Phabricator. Differential Revision: D56418271 |
This pull request has been merged in b1bb0be. |
This pull request was successfully merged by @motiz88 in b1bb0be. When will my fix make it into a release? | How to file a pick request? |
huntie
pushed a commit
that referenced
this pull request
Apr 25, 2024
Summary: Pull Request resolved: #44180 Changelog: [General][Changed] Update Chrome launch flags for `--experimental-debugger` launch flow Internally at Meta, we've been testing the experimental debugger launch flow with a different set of Chrome flags than are currently shipped in open source. This diff fixes those differences: * Removes `--disable-backgrounding-occluded-windows` * Adds `--guest` Reviewed By: EdmondChuiHW Differential Revision: D56418271 fbshipit-source-id: 884c5746e93cad89f17e4ef9e3ef193a2a454eb5
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…ok#44180) Summary: Pull Request resolved: facebook#44180 Changelog: [General][Changed] Update Chrome launch flags for `--experimental-debugger` launch flow Internally at Meta, we've been testing the experimental debugger launch flow with a different set of Chrome flags than are currently shipped in open source. This diff fixes those differences: * Removes `--disable-backgrounding-occluded-windows` * Adds `--guest` Reviewed By: EdmondChuiHW Differential Revision: D56418271 fbshipit-source-id: 884c5746e93cad89f17e4ef9e3ef193a2a454eb5
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ok#44180) Summary: Pull Request resolved: facebook#44180 Changelog: [General][Changed] Update Chrome launch flags for `--experimental-debugger` launch flow Internally at Meta, we've been testing the experimental debugger launch flow with a different set of Chrome flags than are currently shipped in open source. This diff fixes those differences: * Removes `--disable-backgrounding-occluded-windows` * Adds `--guest` Reviewed By: EdmondChuiHW Differential Revision: D56418271 fbshipit-source-id: 884c5746e93cad89f17e4ef9e3ef193a2a454eb5
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Changed] Update Chrome launch flags for
--experimental-debugger
launch flowInternally at Meta, we've been testing the experimental debugger launch flow with a different set of Chrome flags than are currently shipped in open source. This diff fixes those differences:
--disable-backgrounding-occluded-windows
--guest
Reviewed By: EdmondChuiHW
Differential Revision: D56418271