[iOS] [Privacy Manifest] Handle the case where the file reference doesn't have a path #44410

robertying · 2024-05-04T02:29:15Z

Summary:

The new cocoapod post install script includes aggregation and generation of privacy manifests for iOS, which is great. However, the script doesn't consider the case where the file reference doesn't have a path.

Example, for a project setup like the screenshot:

The code

react-native/packages/react-native/scripts/cocoapods/privacy_manifest_utils.rb

Lines 80 to 81 in 05a4232

    
           file_refs = targets.flat_map { |target| target.resources_build_phase.files_references } 
        
           existing_file = file_refs.find { |file_ref| file_ref.path.end_with? "PrivacyInfo.xcprivacy" }

prints file_refs:

[
<PBXFileReference name=`LaunchScreen.storyboard` path=`learnX/LaunchScreen.storyboard` UUID=`81AB9BB72411601600AC10FF`>,
<PBXVariantGroup name=`InfoPlist.strings` UUID=`D40B9F832B248EF5004BC08C`>,
<PBXFileReference path=`AppCenter-Config.plist` UUID=`D40B9F802B248EC2004BC08C`>,
<PBXFileReference name=`PrivacyInfo.xcprivacy` path=`learnX/PrivacyInfo.xcprivacy` UUID=`D403DD362BCA2BCF00E5295C`>,
<PBXFileReference name=`Assets.xcassets` path=`learnX/Assets.xcassets` UUID=`D40B9F652B248AEB004BC08C`>
]

where a PBXVariantGroup exists and it doesn't have path. The error undefined method 'end_with?' for nil occurs as a result.

Changelog:

[IOS] [FIXED] - In privacy manifest post install script, handle the case where the file reference doesn't have a path

Test Plan:

Add a new "Strings File (Legacy)" in Xcode to the project.
Run pod install for iOS.
See the error undefined method 'end_with?' for nil.
Apply the fix and rerun pod install.
The script runs successfully.

cjhlette · 2024-05-04T07:56:48Z

If you use the only image crop picker, react-native-image-crop-picker, you can't use versions 0.74 or higher

I hope this patch will be patched in a short time. Please~

…gation (#28646) # Why There are a few issues right now with privacy manifest aggregation (facebook/react-native#44410, facebook/react-native#44402, facebook/react-native#44402) that I expect will be fixed in React Native 0.74.2, but in order to ensure that this doesn't break builds I've disabled it by default and added this build property to allow folks to toggle it on. We can switch on by default when 0.74.2 is released and proven to handle some edge cases better. # How Same old process for adding a new property # Test Plan Run tests # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).

facebook-github-bot · 2024-05-07T16:23:02Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robertying · 2024-05-09T17:47:44Z

Hi @cipolleschi! I see there is a warning from internal tests. Is there anything I can do to help fix and have this PR merged? Thanks!

lorenc-tomasz · 2024-05-09T18:48:49Z

Hope it will be merge before next release :)

facebook-github-bot · 2024-05-10T09:56:22Z

@cipolleschi merged this pull request in 4ad65ac.

github-actions · 2024-05-10T09:56:24Z

This pull request was successfully merged by @robertying in 4ad65ac.

^{When will my fix make it into a release? | How to file a pick request?}

…k#44410) Summary: The new cocoapod post install script includes aggregation and generation of privacy manifests for iOS, which is great. However, the script doesn't consider the case where the file reference doesn't have a path. Example, for a project setup like the screenshot: <img width="249" alt="image" src="https://github.com/facebook/react-native/assets/22592111/45dd1cf4-c2f6-4abb-940f-136a4d502966"> The code https://github.com/facebook/react-native/blob/05a4232dd591e2d43f192d69ca14a04f4a3fb6a1/packages/react-native/scripts/cocoapods/privacy_manifest_utils.rb#L80-L81 prints `file_refs`: ``` [ <PBXFileReference name=`LaunchScreen.storyboard` path=`learnX/LaunchScreen.storyboard` UUID=`81AB9BB72411601600AC10FF`>, <PBXVariantGroup name=`InfoPlist.strings` UUID=`D40B9F832B248EF5004BC08C`>, <PBXFileReference path=`AppCenter-Config.plist` UUID=`D40B9F802B248EC2004BC08C`>, <PBXFileReference name=`PrivacyInfo.xcprivacy` path=`learnX/PrivacyInfo.xcprivacy` UUID=`D403DD362BCA2BCF00E5295C`>, <PBXFileReference name=`Assets.xcassets` path=`learnX/Assets.xcassets` UUID=`D40B9F652B248AEB004BC08C`> ] ``` where a `PBXVariantGroup` exists and it doesn't have `path`. The error `undefined method 'end_with?' for nil` occurs as a result. ## Changelog:  [IOS] [FIXED] - In privacy manifest post install script, handle the case where the file reference doesn't have a path Pull Request resolved: facebook#44410 Test Plan: 1. Add a new "Strings File (Legacy)" in Xcode to the project. 2. Run `pod install` for iOS. 3. See the error `undefined method 'end_with?' for nil`. 4. Apply the fix and rerun `pod install`. 5. The script runs successfully. Reviewed By: javache Differential Revision: D57056159 Pulled By: cipolleschi fbshipit-source-id: 42caaf1a98efb9111f6ff1014a5c8b7703b042f2

Summary: The new cocoapod post install script includes aggregation and generation of privacy manifests for iOS, which is great. However, the script doesn't consider the case where the file reference doesn't have a path. Example, for a project setup like the screenshot: <img width="249" alt="image" src="https://github.com/facebook/react-native/assets/22592111/45dd1cf4-c2f6-4abb-940f-136a4d502966"> The code https://github.com/facebook/react-native/blob/05a4232dd591e2d43f192d69ca14a04f4a3fb6a1/packages/react-native/scripts/cocoapods/privacy_manifest_utils.rb#L80-L81 prints `file_refs`: ``` [ <PBXFileReference name=`LaunchScreen.storyboard` path=`learnX/LaunchScreen.storyboard` UUID=`81AB9BB72411601600AC10FF`>, <PBXVariantGroup name=`InfoPlist.strings` UUID=`D40B9F832B248EF5004BC08C`>, <PBXFileReference path=`AppCenter-Config.plist` UUID=`D40B9F802B248EC2004BC08C`>, <PBXFileReference name=`PrivacyInfo.xcprivacy` path=`learnX/PrivacyInfo.xcprivacy` UUID=`D403DD362BCA2BCF00E5295C`>, <PBXFileReference name=`Assets.xcassets` path=`learnX/Assets.xcassets` UUID=`D40B9F652B248AEB004BC08C`> ] ``` where a `PBXVariantGroup` exists and it doesn't have `path`. The error `undefined method 'end_with?' for nil` occurs as a result. ## Changelog:  [IOS] [FIXED] - In privacy manifest post install script, handle the case where the file reference doesn't have a path Pull Request resolved: #44410 Test Plan: 1. Add a new "Strings File (Legacy)" in Xcode to the project. 2. Run `pod install` for iOS. 3. See the error `undefined method 'end_with?' for nil`. 4. Apply the fix and rerun `pod install`. 5. The script runs successfully. Reviewed By: javache Differential Revision: D57056159 Pulled By: cipolleschi fbshipit-source-id: 42caaf1a98efb9111f6ff1014a5c8b7703b042f2

…k#44410) Summary: The new cocoapod post install script includes aggregation and generation of privacy manifests for iOS, which is great. However, the script doesn't consider the case where the file reference doesn't have a path. Example, for a project setup like the screenshot: <img width="249" alt="image" src="https://github.com/facebook/react-native/assets/22592111/45dd1cf4-c2f6-4abb-940f-136a4d502966"> The code https://github.com/facebook/react-native/blob/05a4232dd591e2d43f192d69ca14a04f4a3fb6a1/packages/react-native/scripts/cocoapods/privacy_manifest_utils.rb#L80-L81 prints `file_refs`: ``` [ <PBXFileReference name=`LaunchScreen.storyboard` path=`learnX/LaunchScreen.storyboard` UUID=`81AB9BB72411601600AC10FF`>, <PBXVariantGroup name=`InfoPlist.strings` UUID=`D40B9F832B248EF5004BC08C`>, <PBXFileReference path=`AppCenter-Config.plist` UUID=`D40B9F802B248EC2004BC08C`>, <PBXFileReference name=`PrivacyInfo.xcprivacy` path=`learnX/PrivacyInfo.xcprivacy` UUID=`D403DD362BCA2BCF00E5295C`>, <PBXFileReference name=`Assets.xcassets` path=`learnX/Assets.xcassets` UUID=`D40B9F652B248AEB004BC08C`> ] ``` where a `PBXVariantGroup` exists and it doesn't have `path`. The error `undefined method 'end_with?' for nil` occurs as a result. ## Changelog:  [IOS] [FIXED] - In privacy manifest post install script, handle the case where the file reference doesn't have a path Pull Request resolved: facebook#44410 Test Plan: 1. Add a new "Strings File (Legacy)" in Xcode to the project. 2. Run `pod install` for iOS. 3. See the error `undefined method 'end_with?' for nil`. 4. Apply the fix and rerun `pod install`. 5. The script runs successfully. Reviewed By: javache Differential Revision: D57056159 Pulled By: cipolleschi fbshipit-source-id: 42caaf1a98efb9111f6ff1014a5c8b7703b042f2

Summary: The new cocoapod post install script includes aggregation and generation of privacy manifests for iOS, which is great. However, the script doesn't consider the case where the file reference doesn't have a path. Example, for a project setup like the screenshot: <img width="249" alt="image" src="https://github.com/facebook/react-native/assets/22592111/45dd1cf4-c2f6-4abb-940f-136a4d502966"> The code https://github.com/facebook/react-native/blob/05a4232dd591e2d43f192d69ca14a04f4a3fb6a1/packages/react-native/scripts/cocoapods/privacy_manifest_utils.rb#L80-L81 prints `file_refs`: ``` [ <PBXFileReference name=`LaunchScreen.storyboard` path=`learnX/LaunchScreen.storyboard` UUID=`81AB9BB72411601600AC10FF`>, <PBXVariantGroup name=`InfoPlist.strings` UUID=`D40B9F832B248EF5004BC08C`>, <PBXFileReference path=`AppCenter-Config.plist` UUID=`D40B9F802B248EC2004BC08C`>, <PBXFileReference name=`PrivacyInfo.xcprivacy` path=`learnX/PrivacyInfo.xcprivacy` UUID=`D403DD362BCA2BCF00E5295C`>, <PBXFileReference name=`Assets.xcassets` path=`learnX/Assets.xcassets` UUID=`D40B9F652B248AEB004BC08C`> ] ``` where a `PBXVariantGroup` exists and it doesn't have `path`. The error `undefined method 'end_with?' for nil` occurs as a result. ## Changelog:  [IOS] [FIXED] - In privacy manifest post install script, handle the case where the file reference doesn't have a path Pull Request resolved: #44410 Test Plan: 1. Add a new "Strings File (Legacy)" in Xcode to the project. 2. Run `pod install` for iOS. 3. See the error `undefined method 'end_with?' for nil`. 4. Apply the fix and rerun `pod install`. 5. The script runs successfully. Reviewed By: javache Differential Revision: D57056159 Pulled By: cipolleschi fbshipit-source-id: 42caaf1a98efb9111f6ff1014a5c8b7703b042f2

Handle the case where file reference doesn't have a path

e89b637

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 4, 2024

brentvatne mentioned this pull request May 6, 2024

[build-properties] Add field to enable/disable privacy manifest aggregation expo/expo#28646

Merged

3 tasks

aleqsio mentioned this pull request May 8, 2024

Priavacy Policy aggregation errors on get_privacyinfo_file_path #44437

Closed

facebook-github-bot closed this in 4ad65ac May 10, 2024

facebook-github-bot added the Merged This PR has been merged. label May 10, 2024

robertying mentioned this pull request May 10, 2024

[0.74] Pick iOS privacy manifest path fix reactwg/react-native-releases#288

Closed

miallo mentioned this pull request Jun 18, 2024

[0.72] [iOS] [Privacy Manifest] Cherry-pick fix for privacy manifest generation path being nil reactwg/react-native-releases#326

Closed

This was referenced Jun 28, 2024

[CI] Move iOS Executors to M1 #45213

Closed

[Hermes] Bump Hermes #45220

Merged

cipolleschi mentioned this pull request Jul 22, 2024

[RN][0.74]Fix XROS build #45580

Merged

siddharthkul pushed a commit that referenced this pull request Jul 22, 2024

Handle the case where the file reference doesn't have a path (#44410)

a50bad4

siddharthkul pushed a commit that referenced this pull request Jul 22, 2024

Handle the case where the file reference doesn't have a path (#44410)

ada3127

siddharthkul pushed a commit that referenced this pull request Jul 22, 2024

Handle the case where the file reference doesn't have a path (#44410)

b5b3f3c

siddharthkul pushed a commit that referenced this pull request Jul 23, 2024

Handle the case where the file reference doesn't have a path (#44410)

3b7d854

cipolleschi mentioned this pull request Jul 31, 2024

[RN][Hermes] Fore Hermes versions for slices through env var #45840

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] [Privacy Manifest] Handle the case where the file reference doesn't have a path #44410

[iOS] [Privacy Manifest] Handle the case where the file reference doesn't have a path #44410

robertying commented May 4, 2024 •

edited

Loading

cjhlette commented May 4, 2024

facebook-github-bot commented May 7, 2024

robertying commented May 9, 2024

lorenc-tomasz commented May 9, 2024

facebook-github-bot commented May 10, 2024

github-actions bot commented May 10, 2024

	file_refs = targets.flat_map { \|target\| target.resources_build_phase.files_references }
	existing_file = file_refs.find { \|file_ref\| file_ref.path.end_with? "PrivacyInfo.xcprivacy" }

[iOS] [Privacy Manifest] Handle the case where the file reference doesn't have a path #44410

[iOS] [Privacy Manifest] Handle the case where the file reference doesn't have a path #44410

Conversation

robertying commented May 4, 2024 • edited Loading

Summary:

Changelog:

Test Plan:

cjhlette commented May 4, 2024

facebook-github-bot commented May 7, 2024

robertying commented May 9, 2024

lorenc-tomasz commented May 9, 2024

facebook-github-bot commented May 10, 2024

github-actions bot commented May 10, 2024

robertying commented May 4, 2024 •

edited

Loading