Factor hardcoded image paths out in RNTester/Image example, get rid of .ico file #44415
+61
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56978929 |
Base commit: a881b51 |
|
This pull request was exported from Phabricator. Differential Revision: D56978929 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 5, 2024
…f .ico file (facebook#44415) Summary: Pull Request resolved: facebook#44415 # Changelog: [Internal] - RNTester Image example used hardcoded `https://www.facebook.com/favicon.ico`, which has an uncommon ICO format, for no good reason aside of just this image being served from `facebook.com`. This diff: * Replaces the ICO image with a PNG one (which is still served from `facebook.com` * Factors out all the multiple hardcoded paths into constants, so that it's easier to make such changes in the future * Changes another image to something that is a bit better on the eyes when severely downscaled Differential Revision: D56978929
…acebook#44414) Summary: # Changelog: [Internal] - I noticed that "Image/Fade Duration" test in RNTester is practically useless, as at the moment one scrolls to the test, the fading is most probably had already ended. This adds a "button" to refresh the image and be able to see the fading in again and again, if desired. Differential Revision: D56978930
…f .ico file (facebook#44415) Summary: # Changelog: [Internal] - RNTester Image example used hardcoded `https://www.facebook.com/favicon.ico`, which has an uncommon ICO format, for no good reason aside of just this image being served from `facebook.com`. This diff: * Replaces the ICO image with a PNG one (which is still served from `facebook.com` * Factors out all the multiple hardcoded paths into constants, so that it's easier to make such changes in the future * Changes another image to something that is a bit better on the eyes when severely downscaled Differential Revision: D56978929
|
This pull request was exported from Phabricator. Differential Revision: D56978929 |
|
This pull request has been merged in 362abb9. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…f .ico file (facebook#44415) Summary: Pull Request resolved: facebook#44415 # Changelog: [Internal] - RNTester Image example used hardcoded `https://www.facebook.com/favicon.ico`, which has an uncommon ICO format, for no good reason aside of just this image being served from `facebook.com`. This diff: * Replaces the ICO image with a PNG one (which is still served from `facebook.com` * Factors out all the multiple hardcoded paths into constants, so that it's easier to make such changes in the future * Changes another image to something that is a bit better on the eyes when severely downscaled Reviewed By: christophpurrer Differential Revision: D56978929 fbshipit-source-id: c627d1671c8cb66e9a78f4382faa56e539b2f7b3
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…f .ico file (facebook#44415) Summary: Pull Request resolved: facebook#44415 # Changelog: [Internal] - RNTester Image example used hardcoded `https://www.facebook.com/favicon.ico`, which has an uncommon ICO format, for no good reason aside of just this image being served from `facebook.com`. This diff: * Replaces the ICO image with a PNG one (which is still served from `facebook.com` * Factors out all the multiple hardcoded paths into constants, so that it's easier to make such changes in the future * Changes another image to something that is a bit better on the eyes when severely downscaled Reviewed By: christophpurrer Differential Revision: D56978929 fbshipit-source-id: c627d1671c8cb66e9a78f4382faa56e539b2f7b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
RNTester Image example used hardcoded
https://www.facebook.com/favicon.ico, which has an uncommon ICO format, for no good reason aside of just this image being served fromfacebook.com.This diff:
facebook.comDifferential Revision: D56978929