Update ImageExample.windows.js #13283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
reviewed
May 30, 2024
packages/e2e-test-app-fabric/test/__snapshots__/ImageComponentTest.test.ts.snap
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
May 30, 2024
microsoft-github-policy-service
bot
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13280
This re-adds these upstream changes except we're replacing
const IMAGE2 = 'https://www.facebook.com/ar_effect/external_textures/648609739826677.png';with the old uri since the new uri seems to crash the e2etest job (though not observed locally).
const IMAGE2 = 'https://www.facebook.com/ads/pics/successstories.png';#13284 to track why that image is an issue
Microsoft Reviewers: Open in CodeFlow