[Babel] Support plugins that conform to ES6 modules #4513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES6 modules export an object with a property called `default`. See Babel itself for how this is handled: babel/babel@b5b7e34 Test Plan: Used a Babel 6 plugin that is implemented as an ES6 module.
|
cc @martinbigio @tadeuzagallo for review |
|
By analyzing the blame information on this pull request, we identified @davidaurelio, @sebmck and @sahrens to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1665686983713924/int_phab to review. |
10 tasks
|
This got stuck in Sandcastle (we need reporting!). Landing now :) |
ide
added a commit
that referenced
this pull request
Dec 4, 2015
Summary: ES6 modules export an object with a property called `default`. See Babel itself for how this is handled: babel/babel@b5b7e34 Closes #4513 Reviewed By: svcscm Differential Revision: D2715512 Pulled By: mkonicek fb-gh-sync-id: 40e5ea35adcdb66806a4895578d637cd72538619
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: ES6 modules export an object with a property called `default`. See Babel itself for how this is handled: babel/babel@b5b7e34 Closes facebook/react-native#4513 Reviewed By: svcscm Differential Revision: D2715512 Pulled By: mkonicek fb-gh-sync-id: 40e5ea35adcdb66806a4895578d637cd72538619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES6 modules export an object with a property called
default. See Babel itself for how this is handled: babel/babel@b5b7e34Test Plan: Used a Babel 6 plugin that is implemented as an ES6 module.