Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use view.getPaddingStart() directly #45150

Closed
wants to merge 2 commits into from
Closed

use view.getPaddingStart() directly #45150

wants to merge 2 commits into from

Conversation

pengj
Copy link

@pengj pengj commented Jun 24, 2024

Summary:
As the androidx.core 1.13.1 change, we got the error when build this module:

xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.kt:439:24: warning: 'getPaddingStart(View): Int' is deprecated. Deprecated in Java
                ViewCompat.getPaddingStart(scrollView) -
                           ^
    xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.kt:440:24: warning: 'getPaddingEnd(View): Int' is deprecated. Deprecated in Java
                ViewCompat.getPaddingEnd(scrollView))

based on the suggestion:
{F1717102270}

Differential Revision: D58955567

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58955567

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58955567

pengj pushed a commit to pengj/react-native that referenced this pull request Jun 25, 2024
@facebook-github-bot
use view.getPaddingStart() directly (facebook#45150)
cf33068 
Summary:
Pull Request resolved: facebook#45150

As the androidx.core 1.13.1 change, ViewCompact.getPaddingStart and getPaddingEnd are deprecated.

based on the suggestion from the, use :
 {F1717102270}

Reviewed By: alanleedev

Differential Revision: D58955567
Peng Jiang added 2 commits June 25, 2024 10:11
@facebook-github-bot
use view.LAYOUT_DIRECTION_RTL directly
8d9e336 
Differential Revision: D58953460
@facebook-github-bot
use view.getPaddingStart() directly (facebook#45150)
98f7c70 
Summary:
Pull Request resolved: facebook#45150

As the androidx.core 1.13.1 change, ViewCompact.getPaddingStart and getPaddingEnd are deprecated.

based on the suggestion from https://developer.android.com/reference/kotlin/androidx/core/view/ViewCompat#getPaddingStart(android.view.View), use: view.getPaddingStart and view.getPaddingEnd directly.
 {F1717102270}

Changelog: [Internal] - Migrating deprecated APIs with AndroidX.Core 1.13.1

Reviewed By: alanleedev

Differential Revision: D58955567
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58955567

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b9ec0e5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengj @facebook-github-bot