Enable Fusebox by default #45469
Closed
Enable Fusebox by default #45469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enables React Native DevTools by default on `main`, ahead of the 0.76 release. We've observed no new bug reports internally over the last two weeks, and are moving forward with our rollout plan. Changelog: [Internal] Differential Revision: D59804882
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59804882 |
Base commit: 7fd6c2c |
|
This pull request has been merged in c47b04b. |
|
This pull request was successfully merged by @huntie in c47b04b When will my fix make it into a release? | How to file a pick request? |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 7, 2024
Summary: Removes the temporary `unstable_fuseboxEnabled` API on both platforms. Fusebox is enabled by default on `main` since facebook#45469. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60893243
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: #45926 Removes the temporary `unstable_fuseboxEnabled` API on both platforms. Fusebox is enabled by default on `main` since #45469. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60893243 fbshipit-source-id: 7ca4550eafb979730c0c5829df4c200f11e0df30
kaseywolff
pushed a commit
to kaseywolff/react-native
that referenced
this pull request
Aug 19, 2024
Summary: Pull Request resolved: facebook#45469 Enables React Native DevTools by default on `main`, ahead of the 0.76 release. We've observed no new bug reports internally over the last two weeks, and are moving forward with our rollout plan. Changelog: [Internal] Reviewed By: blakef Differential Revision: D59804882 fbshipit-source-id: 0cb6302f4d940718786db2e5d8fb652fae6a8c54
kaseywolff
pushed a commit
to kaseywolff/react-native
that referenced
this pull request
Aug 19, 2024
Summary: Pull Request resolved: facebook#45926 Removes the temporary `unstable_fuseboxEnabled` API on both platforms. Fusebox is enabled by default on `main` since facebook#45469. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60893243 fbshipit-source-id: 7ca4550eafb979730c0c5829df4c200f11e0df30
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 30, 2024
Summary: We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag is not equivalently defined in these build configurations. This diff genericises these checks to `!defined(NDEBUG)` (i.e. *any debug build*), meaning we are correctly able to evaluate the `ReactNativeFeatureFlags::fuseboxEnabledDebug()` setting. Changelog: [Internal] NOTE: `NDEBUG` should be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. Having `HERMES_ENABLE_DEBUGGER` set remains significant (AFAIK) **within the Hermes codebase** (there are no other references in `jsinspector-modern`). Evaluation of whether the lack of this flag works in OSS continues in T200241280. Reviewed By: hoxyq Differential Revision: D61966685
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebook#46282 We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag is not equivalently defined in these build configurations. This diff genericises these checks to `!defined(NDEBUG)` (i.e. *any debug build*), meaning we are correctly able to evaluate the `ReactNativeFeatureFlags::fuseboxEnabledDebug()` setting. Changelog: [Internal] NOTE: `NDEBUG` should be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. Having `HERMES_ENABLE_DEBUGGER` set remains significant (AFAIK) **within the Hermes codebase** (there are no other references in `jsinspector-modern`). Evaluation of whether the lack of this flag works in OSS continues in T200241280. Reviewed By: hoxyq Differential Revision: D61966685
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: #46282 We intended to enable Fusebox on `main` since #45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag is not equivalently defined in these build configurations. This diff genericises these checks to `!defined(NDEBUG)` (i.e. *any debug build*), meaning we are correctly able to evaluate the `ReactNativeFeatureFlags::fuseboxEnabledDebug()` setting. Changelog: [Internal] NOTE: `NDEBUG` should be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. Having `HERMES_ENABLE_DEBUGGER` set remains significant (AFAIK) **within the Hermes codebase** (there are no other references in `jsinspector-modern`). Evaluation of whether the lack of this flag works in OSS continues in T200241280. Reviewed By: hoxyq Differential Revision: D61966685 fbshipit-source-id: d30950172420a0afd6c137dbf014794f3353bb7a
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 9, 2024
Summary: > [!Note] > Replaces facebook#46282. We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag was missing for the `React-jsinspector` Podspec. Differential Revision: D62375148
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ods (#46393) Summary: Pull Request resolved: #46393 > [!Note] > Replaces #46282. We intended to enable Fusebox on `main` since #45469 — this worked when building under Buck, however was not working for builds under Xcode. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag was missing for the `React-jsinspector` Podspec. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D62375148 fbshipit-source-id: 5d4d243d0a2cb7796fdf59d57086a0cb966639c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables React Native DevTools by default on
main, ahead of the 0.76 release. We've observed no new bug reports internally over the last two weeks, and are moving forward with our rollout plan.Changelog: [Internal]
Differential Revision: D59804882