Update InspectorFlags to use NDEBUG flag #46282
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We intended to enable Fusebox on
main
since #45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because theHERMES_ENABLE_DEBUGGER
preprocessor flag is not equivalently defined in these build configurations.This diff genericises these checks to
!defined(NDEBUG)
(i.e. any debug build), meaning we are correctly able to evaluate theReactNativeFeatureFlags::fuseboxEnabledDebug()
setting.Changelog: [Internal]
NOTE:
NDEBUG
should be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. HavingHERMES_ENABLE_DEBUGGER
set remains significant (AFAIK) within the Hermes codebase (there are no other references injsinspector-modern
). Evaluation of whether the lack of this flag works in OSS continues in T200241280.Reviewed By: hoxyq
Differential Revision: D61966685