Commits on Aug 30, 2024

1. Update InspectorFlags to use NDEBUG flag (facebook#46282) …

   Summary:
   Pull Request resolved: facebook#46282
   
   We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag is not equivalently defined in these build configurations.
   
   This diff genericises these checks to `!defined(NDEBUG)` (i.e. *any debug build*), meaning we are correctly able to evaluate the `ReactNativeFeatureFlags::fuseboxEnabledDebug()` setting.
   
   Changelog: [Internal]
   
   NOTE: `NDEBUG` should be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. Having `HERMES_ENABLE_DEBUGGER` set remains significant (AFAIK) **within the Hermes codebase** (there are no other references in `jsinspector-modern`). Evaluation of whether the lack of this flag works in OSS continues in T200241280.
   
   Reviewed By: hoxyq
   
   Differential Revision: D61966685

   

   huntie authored and facebook-github-bot committed Aug 30, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for cb884df
   • Browse repository at this point

   Copy the full SHA

   cb884df View commit details

   Browse the repository at this point in the history