Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL][RN] Revert React from 19Rc to 18.3.1 #45779

Merged
merged 5 commits into from
Jul 29, 2024
Merged

[LOCAL][RN] Revert React from 19Rc to 18.3.1 #45779

merged 5 commits into from
Jul 29, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jul 29, 2024 •
edited
Loading

Summary:

Revert fom React 19-RC to React 18.3.1 because Reacr 19 is not stable.

Changelog:

[General][Changed] - Revert React from 19RC to 18.3.1

Test Plan:

CI is green + release testing

@cipolleschi
Revert ReacRevert React from 19 to 18.3.1 due to React 19 not being o…
398e410 
…ut as stable

\## Changelog
[General][Changed] - Revert from React 19 RC to React 18.3.1
@cipolleschi
Revert from React 19 RC to React 18.3.1
0bea9a3 
\## Changelog
[General][Changed] - Revert from React 19RC to React 18.3.1
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.75-stable July 29, 2024 10:46
@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format
Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 0bea9a3

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 934971e

@cipolleschi cipolleschi mentioned this pull request Jul 29, 2024
Closed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,415,038 -939,818
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,618,934 -931,057
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@cipolleschi cipolleschi marked this pull request as ready for review July 29, 2024 13:35
@cipolleschi cipolleschi merged commit 011118f into 0.75-stable Jul 29, 2024
32 of 33 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/revert-react-to-18 branch July 29, 2024 13:36
This was referenced Aug 15, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cipolleschi @react-native-bot @analysis-bot @cortinico @facebook-github-bot