revise updateState logic for ReactModalHostView (v2) #46359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62286026 |
|
This pull request was exported from Phabricator. Differential Revision: D62286026 |
alanleedev
force-pushed
the
export-D62286026
branch
from
386661e
to
ff2b5b0
Compare
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebook#46359 Remove unneeded code around size calculation and old arch support - updateState was getting called unnecessarily in multiple places --> only call from onSizeChanged() - this is a reliable source for getting the content size area of the dialog used for Modal - remove code checking duplicated update - Old architecture cleanup - Remove Java implementation of ShadowNode - we already have logic to set the node size via UIManagerModule::updateNodeSize(). This code is now group together in updateState() for both new and old architecture This fixes issues with resulting from wrong size calculation: - having gaps at bottom when we set `statusBarTranslucent` to `true` - Modal cut off at bottom on Android 15 (drawn under bottom nav bar) Changelog: [Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge) Differential Revision: D62286026
Summary: Pull Request resolved: facebook#46326 - renaming variabled to make intent more clear - `dialog` -> `dialogWindow` to distinguish with `activity.window` - `hostView` -> `dialogRootViewGroup` as name was confusing. - `ReactModalHostView` creates and manages `DialogRootViewGroup` but it used as contentView for the Dialog. - bug fixes Changelog: [Internal] Differential Revision: D62177564 Reviewed By: mdvacca
|
This pull request was exported from Phabricator. Differential Revision: D62286026 |
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Sep 7, 2024
…6359) Summary: Pull Request resolved: facebook#46359 Remove unneeded code around size calculation and old arch support - updateState was getting called unnecessarily in multiple places --> only call from onSizeChanged() - this is a reliable source for getting the content size area of the dialog used for Modal - remove code checking duplicated update - Old architecture cleanup - Remove Java implementation of ShadowNode - we already have logic to set the node size via UIManagerModule::updateNodeSize(). This code is now group together in updateState() for both new and old architecture This fixes issues with resulting from wrong size calculation: - having gaps at bottom when we set `statusBarTranslucent` to `true` - Modal cut off at bottom on Android 15 (drawn under bottom nav bar) Changelog: [Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge) [Android][Deprecation] - Deprecating ModalHostShadowNode Reviewed By: mdvacca Differential Revision: D62286026
alanleedev
force-pushed
the
export-D62286026
branch
from
ff2b5b0
to
59caa3d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62286026 |
alanleedev
force-pushed
the
export-D62286026
branch
from
59caa3d
to
5cf2874
Compare
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Sep 7, 2024
…6359) Summary: Pull Request resolved: facebook#46359 Remove unneeded code around size calculation and old arch support - updateState was getting called unnecessarily in multiple places --> only call from onSizeChanged() - this is a reliable source for getting the content size area of the dialog used for Modal - remove code checking duplicated update - Old architecture cleanup - Remove Java implementation of ShadowNode - we already have logic to set the node size via UIManagerModule::updateNodeSize(). This code is now group together in updateState() for both new and old architecture This fixes issues with resulting from wrong size calculation: - having gaps at bottom when we set `statusBarTranslucent` to `true` - Modal cut off at bottom on Android 15 (drawn under bottom nav bar) Changelog: [Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge) [Android][Deprecation] - Deprecating ModalHostShadowNode Reviewed By: mdvacca Differential Revision: D62286026
|
This pull request was exported from Phabricator. Differential Revision: D62286026 |
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Sep 7, 2024
…6359) Summary: Pull Request resolved: facebook#46359 Remove unneeded code around size calculation and old arch support - updateState was getting called unnecessarily in multiple places --> only call from onSizeChanged() - this is a reliable source for getting the content size area of the dialog used for Modal - remove code checking duplicated update - Old architecture cleanup - Remove Java implementation of ShadowNode - we already have logic to set the node size via UIManagerModule::updateNodeSize(). This code is now group together in updateState() for both new and old architecture This fixes issues with resulting from wrong size calculation: - having gaps at bottom when we set `statusBarTranslucent` to `true` - Modal cut off at bottom on Android 15 (drawn under bottom nav bar) Changelog: [Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge) [Android][Deprecation] - Deprecating ModalHostShadowNode and ModalHostHelper classes Reviewed By: mdvacca Differential Revision: D62286026
alanleedev
force-pushed
the
export-D62286026
branch
from
5cf2874
to
b8fc691
Compare
…6359) Summary: Pull Request resolved: facebook#46359 Remove unneeded code around size calculation and old arch support - updateState was getting called unnecessarily in multiple places --> only call from onSizeChanged() - this is a reliable source for getting the content size area of the dialog used for Modal - remove code checking duplicated update - Old architecture cleanup - Remove Java implementation of ShadowNode - we already have logic to set the node size via UIManagerModule::updateNodeSize(). This code is now group together in updateState() for both new and old architecture This fixes issues with resulting from wrong size calculation: - having gaps at bottom when we set `statusBarTranslucent` to `true` - Modal cut off at bottom on Android 15 (drawn under bottom nav bar) Changelog: [Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge) [Android][Deprecation] - Deprecating ModalHostShadowNode and ModalHostHelper classes Reviewed By: mdvacca Differential Revision: D62286026
|
This pull request was exported from Phabricator. Differential Revision: D62286026 |
alanleedev
force-pushed
the
export-D62286026
branch
from
b8fc691
to
4eaa215
Compare
|
This pull request has been merged in 77b3a8b. |
|
This pull request was successfully merged by @alanleedev in 77b3a8b When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove unneeded code around size calculation and old arch support
This fixes issues with resulting from wrong size calculation:
statusBarTranslucenttotrueChangelog:
[Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge)
[Android][Deprecation] - Deprecating ModalHostShadowNode and ModalHostHelper classes
Differential Revision: D62286026