Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash that happens with shadow color with 0 alpha #46551

Closed
wants to merge 1 commit into from

Conversation

joevilches
Copy link
Contributor

Summary:
We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Differential Revision: D62899047

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62899047

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62899047

joevilches added a commit to joevilches/react-native that referenced this pull request Sep 17, 2024
Summary:
Pull Request resolved: facebook#46551

We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Differential Revision: D62899047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62899047

joevilches added a commit to joevilches/react-native that referenced this pull request Sep 17, 2024
Summary:
Pull Request resolved: facebook#46551

We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Differential Revision: D62899047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62899047

joevilches added a commit to joevilches/react-native that referenced this pull request Sep 17, 2024
Summary:
Pull Request resolved: facebook#46551

We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D62899047
Summary:
Pull Request resolved: facebook#46551

We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D62899047
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62899047

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7e38cf3.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @joevilches in 7e38cf3

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants