Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash that happens with shadow color with 0 alpha #46551

Closed
wants to merge 1 commit into from
Closed

Fix crash that happens with shadow color with 0 alpha #46551

wants to merge 1 commit into from

Commits on Sep 18, 2024

  1. Fix crash that happens with shadow color with 0 alpha (facebook#46551) 

    Summary:
Pull Request resolved: facebook#46551

We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D62899047
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f42a5ca View commit details
    Browse the repository at this point in the history