Keep BaseTextAttributes as part of AttributedString #46612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63303709 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63303709 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 24, 2024
Summary: Pull Request resolved: facebook#46612 This information is lost by the time the AttributedString makes its way to be measured. Pretty sure I've seen code do incorrect heuristics like grabbing first span for this (IIRC adjustFontSizeToFit does this)? Another case where we hit this on Android is when the last character is a newline (which is part of the Spannable), and layout needs to predict the size of the line which will come next (where it uses the EditText's underlying TextPaint, who is using these base attributes). Changelog: [Internal] Differential Revision: D63303709
NickGerleman
force-pushed
the
export-D63303709
branch
from
9419315 to
f3fbcab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63303709 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebook#46612 This information is lost by the time the AttributedString makes its way to be measured. Pretty sure I've seen code do incorrect heuristics like grabbing first span for this (IIRC adjustFontSizeToFit does this)? Another case where we hit this on Android is when the last character is a newline (which is part of the Spannable), and layout needs to predict the size of the line which will come next (where it uses the EditText's underlying TextPaint, who is using these base attributes). Changelog: [Internal] Differential Revision: D63303709
NickGerleman
force-pushed
the
export-D63303709
branch
from
f3fbcab to
77f432d
Compare
Summary: This information is lost by the time the AttributedString makes its way to be measured. Pretty sure I've seen code do incorrect heuristics like grabbing first span for this (IIRC adjustFontSizeToFit does this)? Another case where we hit this on Android is when the last character is a newline (which is part of the Spannable), and layout needs to predict the size of the line which will come next (where it uses the EditText's underlying TextPaint, who is using these base attributes). Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D63303709
NickGerleman
force-pushed
the
export-D63303709
branch
from
77f432d to
f41d855
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63303709 |
Contributor
|
This pull request has been merged in a11a7c3. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in a11a7c3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This information is lost by the time the AttributedString makes its way to be measured.
Pretty sure I've seen code do incorrect heuristics like grabbing first span for this (IIRC adjustFontSizeToFit does this)? Another case where we hit this on Android is when the last character is a newline (which is part of the Spannable), and layout needs to predict the size of the line which will come next (where it uses the EditText's underlying TextPaint, who is using these base attributes).
Changelog: [Internal]
Differential Revision: D63303709